Runtime::getRawBinary()

[staabm]

to pass a command in array-notation to proc_open we need it in a raw form. the escaping happens by php-src itself

refs sebastianbergmann/phpunit#5749 (comment)

[staabm]

after this change even the hardcoded 'php' (line 126) is passed thru escapeshellarg, which wasn't the case before.

tested locally on my macos, that this still works as expected

[staabm]

looking at phpunit 10.5 I need this change in the next 6.x release to be useful

[sebastianbergmann]

looking at phpunit 10.5 I need this change in the next 6.x release to be useful

Then this should target the 6.0 branch :)

[codecov]

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.77%. Comparing base (e855a4b) to head (7c0c4fc).

Files	Patch %	Lines
src/Runtime.php	80.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main      #72      +/-   ##
============================================
+ Coverage     55.17%   56.77%   +1.60%     
- Complexity       67       68       +1     
============================================
  Files             2        2              
  Lines           116      118       +2     
============================================
+ Hits             64       67       +3     
+ Misses           52       51       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sebastianbergmann]

I will create a 6.1 branch and cherry-pick this.

[staabm]

I will create a 6.1 branch and cherry-pick this.

thank you

[sebastianbergmann]

I have created the 6.1 branch (and delete the 6.0 branch), merged your changes, and tagged 6.1.0. Took a while longer than expected as I had to write about something ;-)

Next step: merge to main and tag 7.1.0 for PHPUnit 11.

[sebastianbergmann]

7.1.0 has been tagged and composer.lock was updated on the 10.5, 11.0, and main branches of PHPUnit.

[staabm]

Thanks. No hurry I am afk until later today