Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

method canBeSerialized implemented #3

Closed
wants to merge 4 commits into from
Closed

method canBeSerialized implemented #3

wants to merge 4 commits into from

Conversation

tael
Copy link

@tael tael commented Feb 25, 2015

implements properly!

i'm not sure about write the test-code with phpUnit,
please someone improves that.

and i have no idea for 100 over recursive calls :(

  • it means class or array have 100 over depth. (really rarely)

tael referenced this pull request Feb 25, 2015
@whatthejeff
Improve the canBeSerialized method a little.
c217a59
@tael
Copy link
Author

tael commented Feb 25, 2015

related c217a59

@tael
Copy link
Author

tael commented Feb 25, 2015

i don't know that why DOMDocument can not be serialize...
DOMDocument::loadXML(): Empty string supplied as input

@whatthejeff
Copy link
Collaborator

@tael Internal classes and classes extending internal classes can not be considered serializable if they do not implement the Serializable interface.

@tael
Copy link
Author

tael commented Feb 25, 2015

@whatthejeff
yea, i realized something is wrong :(
could you leave the link about 'Internal classes' ?
I think that I'm missing something conceptional.

@whatthejeff
Copy link
Collaborator

@tael http://php.net/manual/en/function.serialize.php#refsect1-function.serialize-notes

@tael
Copy link
Author

tael commented Feb 25, 2015

@whatthejeff
oh, thanks !
I did not understood your code, and try to fix something.
what a foolish..
I will try fix more. thank you!

@tael
Copy link
Author

tael commented Feb 28, 2015

can someone check this PR? with any comment to improve :-)

mrclay
mrclay reviewed Oct 11, 2015
View reviewed changes
src/Snapshot.php
}
$o = new \ReflectionObject($variable);
$properties = $o->getProperties(\ReflectionProperty::IS_STATIC | \ReflectionProperty::IS_PUBLIC | \ReflectionProperty::IS_PROTECTED);
foreach ($properties as $p) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this traverse dynamically added properties?

@elazar elazar mentioned this pull request Oct 13, 2015
Closed
@malkusch malkusch mentioned this pull request Nov 3, 2015
Closed
@sebastianbergmann
Copy link
Owner

Sorry for dropping the ball on this. In case you're still interested in this, @tael, feel free to open a new pull request that uses https://github.com/sebastianbergmann/object-enumerator for looking at all objects of an object graph. See #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tael @whatthejeff @sebastianbergmann @mrclay