#864 Uncovered files should be ignored unless requested #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 9.2 #868 +/- ##
============================================
- Coverage 83.26% 83.10% -0.16%
- Complexity 1111 1116 +5
============================================
Files 62 62
Lines 3645 3652 +7
============================================
Hits 3035 3035
- Misses 610 617 +7
Continue to review full report at Codecov.
|
Slamdunk
reviewed
Feb 7, 2022
| continue 2; | ||
| } | ||
| } | ||
| unset($file); |
There was a problem hiding this comment.
This addition does nothing: unsetting $file does not alter $this->lineCoverage.
Commenting the whole removeFilesWithNoCoverage content still makes the tests pass
There was a problem hiding this comment.
Well, that's embarrassing...
There was a problem hiding this comment.
Not only for you, also for me, because I reviewed this ;)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for version 9
There are too many permutations of the various scenarios (
includeUncoveredFiles = true|false,processUncoveredFiles = true|false,@covers passing|failingfor the file,@covers passing|failingfor an individual method,@codeCoverageIgnoreannotations etc, multiplied by whether the file/method has been seen already or if this is the first time to sensibly try and disentangle the necessary code paths within->append().Therefore don't even try during the collection phase, just deal with it at report generation time instead.