New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage failure in case of an invalid file #973
Conversation
Codecov Report
@@ Coverage Diff @@
## 9.2 #973 +/- ##
============================================
- Coverage 84.29% 84.28% -0.01%
- Complexity 1178 1184 +6
============================================
Files 59 59
Lines 4215 4220 +5
============================================
+ Hits 3553 3557 +4
- Misses 662 663 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@sebastianbergmann Could you check that please? Thank you |
I did not have time yet to review this. In the meantime, please fix the coding guidlines violations. Thanks! |
I hope I did it correctly. I don't know because even composer update fails on my machine and I have to wait for workflow approval. You could change settings for approval on page https://github.com/sebastianbergmann/php-code-coverage/settings/actions so only new GitHub users have to wait Composer reports this
|
Well, apparently only thing I needed was to set |
My lib supports two incompatible versions of a dependency. Code for newer version extends class that does not exist in older one. Currently code coverage fails with
Uncaught Error: Class 'Latte\Extension' not found
https://github.com/orisai/localization/actions/runs/3766553046/jobs/6403184303After applying the fix, coverage no longer fails. And file is correctly reported as uncovered.
orisai/localization@a0f7a0b
https://github.com/orisai/localization/actions/runs/3766885353