Add description to suggested composer packages #985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
composer.json
Outdated
| @@ -47,8 +47,8 @@ | |||
| "phpunit/phpunit": "^10.1" | |||
| }, | |||
| "suggest": { | |||
| "ext-pcov": "*", | |||
| "ext-xdebug": "*" | |||
| "ext-pcov": "A fast code coverage driver", | |||
There was a problem hiding this comment.
A better description would be "PHP extension that provides line coverage".
composer.json
Outdated
| "ext-pcov": "*", | ||
| "ext-xdebug": "*" | ||
| "ext-pcov": "A fast code coverage driver", | ||
| "ext-xdebug": "Code coverage driver" |
There was a problem hiding this comment.
A better description would be "PHP extension that provides line coverage as well as branch and path coverage".
There was a problem hiding this comment.
Thanks, I updated both descriptions
The value in suggestions is not for the version (like in required) but for a descriptive test that can help developers in deciding if they should install the suggested package. This hint will be show to developers when running `composer suggests`
|
Cherry-picked into |
|
Thank you for the quick review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value in suggestions is not for the version (like in required) but for a descriptive test that can help developers in deciding if they should install the suggested package.
This hint will be show to developers when running
composer suggests