This repository has been archived by the owner on Jul 26, 2021. It is now read-only.
getEndTokenId does not handle string-dollar "${var}" interpolation #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
============================================
+ Coverage 77.29% 77.34% +0.04%
- Complexity 210 211 +1
============================================
Files 3 3
Lines 511 512 +1
============================================
+ Hits 395 396 +1
Misses 116 116
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the PHP_TokenWithScope::getEndTokenId function that manifests as coverage issues in PHPUnit.
The opening token of the string-dollar style variable interpolation "${var}" (PHP_Token_DOLLAR_OPEN_CURLY_BRACES) is not recognized by the function when determining block depth. This causes an off-by-one error and results in the next-to-last close brace being seen as the end line of the function. This cascades into php-code-coverage/PHPUnit as the end of the function being treated as ignored/non-executable.