Shouldn't use ReflectionParameter::hasType in case of running on HHVM

[slashmili]

MockObject_Generator uses ReflectionParameter to extract the methods
information. Because ReflectionParameter can extract
the correct method type, it could possibly extracts Vector<Pair<string, string>>
as the type and then later tries to eval the generated code
with correct type. However since eval gets triggered from
MockObject_Generator in php and this syntax is not valid for PHP, the
test fails with syntax error

[nicolas-grekas]

This will break contracts specified by interfaces, isn't it? If yes, then we need to be more clever...
Personally, I hit this issue when mocking the internal Memcache class.
What class are you mocking? A userland one coded in hack or an internal one?

[slashmili]

I am testing userland hacklang code. The class is like:

class Foo
{
    public function bar(Vector<Pair<string, string>> $keyValues) {
    }
}

This will break contracts specified by interfaces, isn't it?

As you might already know, If you want to test a hacklang class in PHPUnit tests, the file should be in partial mode. So HHVM doesn't complain if the bar interface is like public function bar(\HH\Vector $keyValues)

[slashmili]

Could someone provide a guide or merge this PL?

Without this change PHPUnit doesn't support HHVM 3.10 and above