Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started page for Money.php #4

Closed
Jnesselr opened this issue Jan 25, 2014 · 2 comments
Closed

Getting Started page for Money.php #4

Jnesselr opened this issue Jan 25, 2014 · 2 comments

Comments

@Jnesselr
Copy link

The getting started page (http://phpunit.de/getting-started.html) actually shows a test failure because $amount is null when the test is run. I fixed this when I was testing it by simply adding a constructor in the Money class that set the $amount variable correctly.

@sebastianbergmann
Copy link
Owner

The

// ...

in the example indicates that the code shown is an excerpt. And there is a link to the complete sourcecode.

@Jnesselr
Copy link
Author

My assertion is simply that as a phpunit example, it should be a complete, yet small example. Adding the constructor would make it such a sample. I knew that the comments meant other code was supposed to be there, however I assumed that it would have enough code to actually test it. After all, it is on the getting started page. I don't want to grab the entire code if I can just test it with that little bitty bit.

sebastianbergmann added a commit that referenced this issue Jan 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants