Remove superfluous code

sebastianbergmann · Dec 27, 2023 · 0150f4d · 0150f4d
1 parent daa968e
commit 0150f4d
Show file tree

Hide file tree

Showing 22 changed files with 11 additions and 110 deletions.
diff --git a/src/TextUI/Configuration/Value/ConstantCollectionIterator.php b/src/TextUI/Configuration/Value/ConstantCollectionIterator.php
@@ -10,16 +10,14 @@
 namespace PHPUnit\TextUI\Configuration;
 
 use function count;
-use function iterator_count;
-use Countable;
 use Iterator;
 
 /**
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
  *
  * @template-implements Iterator<int, Constant>
  */
-final class ConstantCollectionIterator implements Countable, Iterator
+final class ConstantCollectionIterator implements Iterator
 {
     /**
      * @psalm-var list<Constant>
@@ -32,11 +30,6 @@ public function __construct(ConstantCollection $constants)
         $this->constants = $constants->asArray();
     }
 
-    public function count(): int
-    {
-        return iterator_count($this);
-    }
-
     public function rewind(): void
     {
         $this->position = 0;

diff --git a/src/TextUI/Configuration/Value/DirectoryCollectionIterator.php b/src/TextUI/Configuration/Value/DirectoryCollectionIterator.php
@@ -10,16 +10,14 @@
 namespace PHPUnit\TextUI\Configuration;
 
 use function count;
-use function iterator_count;
-use Countable;
 use Iterator;
 
 /**
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
  *
  * @template-implements Iterator<int, Directory>
  */
-final class DirectoryCollectionIterator implements Countable, Iterator
+final class DirectoryCollectionIterator implements Iterator
 {
     /**
      * @psalm-var list<Directory>
@@ -32,11 +30,6 @@ public function __construct(DirectoryCollection $directories)
         $this->directories = $directories->asArray();
     }
 
-    public function count(): int
-    {
-        return iterator_count($this);
-    }
-
     public function rewind(): void
     {
         $this->position = 0;

diff --git a/src/TextUI/Configuration/Value/ExtensionBootstrapCollectionIterator.php b/src/TextUI/Configuration/Value/ExtensionBootstrapCollectionIterator.php
@@ -10,16 +10,14 @@
 namespace PHPUnit\TextUI\Configuration;
 
 use function count;
-use function iterator_count;
-use Countable;
 use Iterator;
 
 /**
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
  *
  * @template-implements Iterator<int, ExtensionBootstrap>
  */
-final class ExtensionBootstrapCollectionIterator implements Countable, Iterator
+final class ExtensionBootstrapCollectionIterator implements Iterator
 {
     /**
      * @psalm-var list<ExtensionBootstrap>
@@ -32,11 +30,6 @@ public function __construct(ExtensionBootstrapCollection $extensionBootstraps)
         $this->extensionBootstraps = $extensionBootstraps->asArray();
     }
 
-    public function count(): int
-    {
-        return iterator_count($this);
-    }
-
     public function rewind(): void
     {
         $this->position = 0;

diff --git a/src/TextUI/Configuration/Value/FileCollectionIterator.php b/src/TextUI/Configuration/Value/FileCollectionIterator.php
@@ -10,16 +10,14 @@
 namespace PHPUnit\TextUI\Configuration;
 
 use function count;
-use function iterator_count;
-use Countable;
 use Iterator;
 
 /**
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
  *
  * @template-implements Iterator<int, File>
  */
-final class FileCollectionIterator implements Countable, Iterator
+final class FileCollectionIterator implements Iterator
 {
     /**
      * @psalm-var list<File>
@@ -32,11 +30,6 @@ public function __construct(FileCollection $files)
         $this->files = $files->asArray();
     }
 
-    public function count(): int
-    {
-        return iterator_count($this);
-    }
-
     public function rewind(): void
     {
         $this->position = 0;

diff --git a/src/TextUI/Configuration/Value/FilterDirectoryCollectionIterator.php b/src/TextUI/Configuration/Value/FilterDirectoryCollectionIterator.php
@@ -10,16 +10,14 @@
 namespace PHPUnit\TextUI\Configuration;
 
 use function count;
-use function iterator_count;
-use Countable;
 use Iterator;
 
 /**
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
  *
  * @template-implements Iterator<int, FilterDirectory>
  */
-final class FilterDirectoryCollectionIterator implements Countable, Iterator
+final class FilterDirectoryCollectionIterator implements Iterator
 {
     /**
      * @psalm-var list<FilterDirectory>
@@ -32,11 +30,6 @@ public function __construct(FilterDirectoryCollection $directories)
         $this->directories = $directories->asArray();
     }
 
-    public function count(): int
-    {
-        return iterator_count($this);
-    }
-
     public function rewind(): void
     {
         $this->position = 0;

diff --git a/src/TextUI/Configuration/Value/GroupCollectionIterator.php b/src/TextUI/Configuration/Value/GroupCollectionIterator.php
@@ -10,16 +10,14 @@
 namespace PHPUnit\TextUI\Configuration;
 
 use function count;
-use function iterator_count;
-use Countable;
 use Iterator;
 
 /**
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
  *
  * @template-implements Iterator<int, Group>
  */
-final class GroupCollectionIterator implements Countable, Iterator
+final class GroupCollectionIterator implements Iterator
 {
     /**
      * @psalm-var list<Group>
@@ -32,11 +30,6 @@ public function __construct(GroupCollection $groups)
         $this->groups = $groups->asArray();
     }
 
-    public function count(): int
-    {
-        return iterator_count($this);
-    }
-
     public function rewind(): void
     {
         $this->position = 0;

diff --git a/src/TextUI/Configuration/Value/IniSettingCollectionIterator.php b/src/TextUI/Configuration/Value/IniSettingCollectionIterator.php
@@ -10,16 +10,14 @@
 namespace PHPUnit\TextUI\Configuration;
 
 use function count;
-use function iterator_count;
-use Countable;
 use Iterator;
 
 /**
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
  *
  * @template-implements Iterator<int, IniSetting>
  */
-final class IniSettingCollectionIterator implements Countable, Iterator
+final class IniSettingCollectionIterator implements Iterator
 {
     /**
      * @psalm-var list<IniSetting>
@@ -32,11 +30,6 @@ public function __construct(IniSettingCollection $iniSettings)
         $this->iniSettings = $iniSettings->asArray();
     }
 
-    public function count(): int
-    {
-        return iterator_count($this);
-    }
-
     public function rewind(): void
     {
         $this->position = 0;

diff --git a/src/TextUI/Configuration/Value/TestDirectoryCollectionIterator.php b/src/TextUI/Configuration/Value/TestDirectoryCollectionIterator.php
@@ -10,16 +10,14 @@
 namespace PHPUnit\TextUI\Configuration;
 
 use function count;
-use function iterator_count;
-use Countable;
 use Iterator;
 
 /**
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
  *
  * @template-implements Iterator<int, TestDirectory>
  */
-final class TestDirectoryCollectionIterator implements Countable, Iterator
+final class TestDirectoryCollectionIterator implements Iterator
 {
     /**
      * @psalm-var list<TestDirectory>
@@ -32,11 +30,6 @@ public function __construct(TestDirectoryCollection $directories)
         $this->directories = $directories->asArray();
     }
 
-    public function count(): int
-    {
-        return iterator_count($this);
-    }
-
     public function rewind(): void
     {
         $this->position = 0;

diff --git a/src/TextUI/Configuration/Value/TestFileCollectionIterator.php b/src/TextUI/Configuration/Value/TestFileCollectionIterator.php
@@ -10,16 +10,14 @@
 namespace PHPUnit\TextUI\Configuration;
 
 use function count;
-use function iterator_count;
-use Countable;
 use Iterator;
 
 /**
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
  *
  * @template-implements Iterator<int, TestFile>
  */
-final class TestFileCollectionIterator implements Countable, Iterator
+final class TestFileCollectionIterator implements Iterator
 {
     /**
      * @psalm-var list<TestFile>
@@ -32,11 +30,6 @@ public function __construct(TestFileCollection $files)
         $this->files = $files->asArray();
     }
 
-    public function count(): int
-    {
-        return iterator_count($this);
-    }
-
     public function rewind(): void
     {
         $this->position = 0;

diff --git a/src/TextUI/Configuration/Value/TestSuiteCollectionIterator.php b/src/TextUI/Configuration/Value/TestSuiteCollectionIterator.php
@@ -10,16 +10,14 @@
 namespace PHPUnit\TextUI\Configuration;
 
 use function count;
-use function iterator_count;
-use Countable;
 use Iterator;
 
 /**
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
  *
  * @template-implements Iterator<int, TestSuite>
  */
-final class TestSuiteCollectionIterator implements Countable, Iterator
+final class TestSuiteCollectionIterator implements Iterator
 {
     /**
      * @psalm-var list<TestSuite>
@@ -32,11 +30,6 @@ public function __construct(TestSuiteCollection $testSuites)
         $this->testSuites = $testSuites->asArray();
     }
 
-    public function count(): int
-    {
-        return iterator_count($this);
-    }
-
     public function rewind(): void
     {
         $this->position = 0;

diff --git a/src/TextUI/Configuration/Value/VariableCollectionIterator.php b/src/TextUI/Configuration/Value/VariableCollectionIterator.php
@@ -10,16 +10,14 @@
 namespace PHPUnit\TextUI\Configuration;
 
 use function count;
-use function iterator_count;
-use Countable;
 use Iterator;
 
 /**
  * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
  *
  * @template-implements Iterator<int, Variable>
  */
-final class VariableCollectionIterator implements Countable, Iterator
+final class VariableCollectionIterator implements Iterator
 {
     /**
      * @psalm-var list<Variable>
@@ -32,11 +30,6 @@ public function __construct(VariableCollection $variables)
         $this->variables = $variables->asArray();
     }
 
-    public function count(): int
-    {
-        return iterator_count($this);
-    }
-
     public function rewind(): void
     {
         $this->position = 0;

diff --git a/tests/unit/TextUI/Configuration/Value/ConstantCollectionTest.php b/tests/unit/TextUI/Configuration/Value/ConstantCollectionTest.php
@@ -41,8 +41,6 @@ public function testIsIterable(): void
         $element  = $this->element();
         $elements = ConstantCollection::fromArray([$element]);
 
-        $this->assertCount(1, $elements->getIterator());
-
         foreach ($elements as $index => $_constant) {
             $this->assertSame(0, $index);
             $this->assertSame($element, $_constant);

diff --git a/tests/unit/TextUI/Configuration/Value/DirectoryCollectionTest.php b/tests/unit/TextUI/Configuration/Value/DirectoryCollectionTest.php
@@ -42,8 +42,6 @@ public function testIsIterable(): void
         $element  = $this->element();
         $elements = DirectoryCollection::fromArray([$element]);
 
-        $this->assertCount(1, $elements->getIterator());
-
         foreach ($elements as $index => $_constant) {
             $this->assertSame(0, $index);
             $this->assertSame($element, $_constant);

diff --git a/tests/unit/TextUI/Configuration/Value/ExtensionBootstrapCollectionTest.php b/tests/unit/TextUI/Configuration/Value/ExtensionBootstrapCollectionTest.php
@@ -33,8 +33,6 @@ public function testIsIterable(): void
         $element  = $this->element();
         $elements = ExtensionBootstrapCollection::fromArray([$element]);
 
-        $this->assertCount(1, $elements->getIterator());
-
         foreach ($elements as $index => $_constant) {
             $this->assertSame(0, $index);
             $this->assertSame($element, $_constant);

diff --git a/tests/unit/TextUI/Configuration/Value/FileCollectionTest.php b/tests/unit/TextUI/Configuration/Value/FileCollectionTest.php
@@ -42,8 +42,6 @@ public function testIsIterable(): void
         $element  = $this->element();
         $elements = FileCollection::fromArray([$element]);
 
-        $this->assertCount(1, $elements->getIterator());
-
         foreach ($elements as $index => $_constant) {
             $this->assertSame(0, $index);
             $this->assertSame($element, $_constant);

diff --git a/tests/unit/TextUI/Configuration/Value/FilterDirectoryCollectionTest.php b/tests/unit/TextUI/Configuration/Value/FilterDirectoryCollectionTest.php
@@ -42,8 +42,6 @@ public function testIsIterable(): void
         $element  = $this->element();
         $elements = FilterDirectoryCollection::fromArray([$element]);
 
-        $this->assertCount(1, $elements->getIterator());
-
         foreach ($elements as $index => $_constant) {
             $this->assertSame(0, $index);
             $this->assertSame($element, $_constant);

diff --git a/tests/unit/TextUI/Configuration/Value/GroupCollectionTest.php b/tests/unit/TextUI/Configuration/Value/GroupCollectionTest.php
@@ -34,8 +34,6 @@ public function testIsIterable(): void
         $element  = $this->element();
         $elements = GroupCollection::fromArray([$element]);
 
-        $this->assertCount(1, $elements->getIterator());
-
         foreach ($elements as $index => $_constant) {
             $this->assertSame(0, $index);
             $this->assertSame($element, $_constant);

diff --git a/tests/unit/TextUI/Configuration/Value/IniSettingCollectionTest.php b/tests/unit/TextUI/Configuration/Value/IniSettingCollectionTest.php
@@ -41,8 +41,6 @@ public function testIsIterable(): void
         $element  = $this->element();
         $elements = IniSettingCollection::fromArray([$element]);
 
-        $this->assertCount(1, $elements->getIterator());
-
         foreach ($elements as $index => $_IniSetting) {
             $this->assertSame(0, $index);
             $this->assertSame($element, $_IniSetting);