Fix: Use class keyword

sebastianbergmann · Mar 8, 2022 · 0461f96 · 0461f96
1 parent 68b9ace
commit 0461f96
Show file tree

Hide file tree

Showing 15 changed files with 262 additions and 106 deletions.
diff --git a/tests/unit/Framework/AssertTest.php b/tests/unit/Framework/AssertTest.php
@@ -214,20 +214,20 @@ public function testAssertArrayNotContainsOnlyIntegers(): void
 
     public function testAssertArrayContainsOnlyStdClass(): void
     {
-        $this->assertContainsOnly('StdClass', [new stdClass]);
+        $this->assertContainsOnly(stdClass::class, [new stdClass]);
 
         $this->expectException(AssertionFailedError::class);
 
-        $this->assertContainsOnly('StdClass', ['StdClass']);
+        $this->assertContainsOnly(stdClass::class, [stdClass::class]);
     }
 
     public function testAssertArrayNotContainsOnlyStdClass(): void
     {
-        $this->assertNotContainsOnly('StdClass', ['StdClass']);
+        $this->assertNotContainsOnly(stdClass::class, [stdClass::class]);
 
         $this->expectException(AssertionFailedError::class);
 
-        $this->assertNotContainsOnly('StdClass', [new stdClass]);
+        $this->assertNotContainsOnly(stdClass::class, [new stdClass]);
     }
 
     public function equalProvider(): array
@@ -930,7 +930,7 @@ public function testAssertThatIdenticalTo(): void
 
     public function testAssertThatIsInstanceOf(): void
     {
-        $this->assertThat(new stdClass, $this->isInstanceOf('StdClass'));
+        $this->assertThat(new stdClass, $this->isInstanceOf(stdClass::class));
     }
 
     public function testAssertThatIsType(): void
@@ -1412,7 +1412,7 @@ public function testAssertInstanceOfThrowsExceptionIfTypeDoesNotExist(): void
     {
         $this->expectException(Exception::class);
 
-        $this->assertInstanceOf('ClassThatDoesNotExist', new stdClass);
+        $this->assertInstanceOf(ClassThatDoesNotExist::class, new stdClass);
     }
 
     public function testAssertInstanceOf(): void
@@ -1428,7 +1428,7 @@ public function testAssertNotInstanceOfThrowsExceptionIfTypeDoesNotExist(): void
     {
         $this->expectException(Exception::class);
 
-        $this->assertNotInstanceOf('ClassThatDoesNotExist', new stdClass);
+        $this->assertNotInstanceOf(ClassThatDoesNotExist::class, new stdClass);
     }
 
     public function testAssertNotInstanceOf(): void

diff --git a/tests/unit/Framework/Constraint/ClassHasAttributeTest.php b/tests/unit/Framework/Constraint/ClassHasAttributeTest.php
@@ -33,11 +33,14 @@ public function testConstraintClassHasAttribute(): void
             $constraint->evaluate(stdClass::class);
         } catch (ExpectationFailedException $e) {
             $this->assertEquals(
-                <<<'EOF'
-Failed asserting that class "stdClass" has attribute "privateAttribute".
+                sprintf(
+                    <<<'EOF'
+Failed asserting that class "%s" has attribute "privateAttribute".
 
 EOF
-                ,
+                    ,
+                    stdClass::class
+                ),
                 TestFailure::exceptionToString($e)
             );
 
@@ -57,12 +60,15 @@ public function testConstraintClassHasAttribute2(): void
             $constraint->evaluate(stdClass::class, 'custom message');
         } catch (ExpectationFailedException $e) {
             $this->assertEquals(
-                <<<'EOF'
+                sprintf(
+                    <<<'EOF'
 custom message
-Failed asserting that class "stdClass" has attribute "privateAttribute".
+Failed asserting that class "%s" has attribute "privateAttribute".
 
 EOF
-                ,
+                    ,
+                    stdClass::class
+                ),
                 TestFailure::exceptionToString($e)
             );
 

diff --git a/tests/unit/Framework/Constraint/ClassHasStaticAttributeTest.php b/tests/unit/Framework/Constraint/ClassHasStaticAttributeTest.php
@@ -31,11 +31,14 @@ public function testConstraintClassHasStaticAttribute(): void
             $constraint->evaluate(stdClass::class);
         } catch (ExpectationFailedException $e) {
             $this->assertEquals(
-                <<<'EOF'
-Failed asserting that class "stdClass" has static attribute "privateStaticAttribute".
+                sprintf(
+                    <<<'EOF'
+Failed asserting that class "%s" has static attribute "privateStaticAttribute".
 
 EOF
-                ,
+                    ,
+                    stdClass::class
+                ),
                 TestFailure::exceptionToString($e)
             );
 
@@ -53,12 +56,15 @@ public function testConstraintClassHasStaticAttribute2(): void
             $constraint->evaluate(stdClass::class, 'custom message');
         } catch (ExpectationFailedException $e) {
             $this->assertEquals(
-                <<<'EOF'
+                sprintf(
+                    <<<'EOF'
 custom message
-Failed asserting that class "stdClass" has static attribute "foo".
+Failed asserting that class "%s" has static attribute "foo".
 
 EOF
-                ,
+                    ,
+                    stdClass::class
+                ),
                 TestFailure::exceptionToString($e)
             );
 

diff --git a/tests/unit/Framework/Constraint/IsIdenticalTest.php b/tests/unit/Framework/Constraint/IsIdenticalTest.php
@@ -26,7 +26,13 @@ public function testConstraintIsIdentical(): void
 
         $this->assertFalse($constraint->evaluate($b, '', true));
         $this->assertTrue($constraint->evaluate($a, '', true));
-        $this->assertEquals('is identical to an object of class "stdClass"', $constraint->toString());
+        $this->assertEquals(
+            sprintf(
+                'is identical to an object of class "%s"',
+                stdClass::class
+            ),
+            $constraint->toString()
+        );
         $this->assertCount(1, $constraint);
 
         try {

diff --git a/tests/unit/Framework/Constraint/IsInstanceOfTest.php b/tests/unit/Framework/Constraint/IsInstanceOfTest.php
@@ -30,14 +30,18 @@ public function testConstraintFailsOnString(): void
         $constraint = new IsInstanceOf(stdClass::class);
 
         try {
-            $constraint->evaluate('stdClass');
+            $constraint->evaluate(stdClass::class);
         } catch (ExpectationFailedException $e) {
             $this->assertSame(
-                <<<'EOT'
-Failed asserting that 'stdClass' is an instance of class "stdClass".
+                sprintf(
+                    <<<'EOT'
+Failed asserting that '%s' is an instance of class "%s".
 
 EOT
-                ,
+                    ,
+                    stdClass::class,
+                    stdClass::class
+                ),
                 TestFailure::exceptionToString($e)
             );
         }
@@ -50,7 +54,10 @@ public function testCronstraintsThrowsReflectionException(): void
         $constraint = new IsInstanceOf(NotExistingClass::class);
 
         $this->assertSame(
-            'is instance of class "PHPUnit\Framework\Constraint\NotExistingClass"',
+            sprintf(
+                'is instance of class "%s"',
+                NotExistingClass::class
+            ),
             $constraint->toString()
         );
     }

diff --git a/tests/unit/Framework/Constraint/IsTypeTest.php b/tests/unit/Framework/Constraint/IsTypeTest.php
@@ -36,11 +36,14 @@ public function testConstraintIsType(): void
             $constraint->evaluate(new stdClass);
         } catch (ExpectationFailedException $e) {
             $this->assertStringMatchesFormat(
-                <<<'EOF'
-Failed asserting that stdClass Object #%d () is of type "string".
+                sprintf(
+                    <<<'EOF'
+Failed asserting that %s Object #%%d () is of type "string".
 
 EOF
-                ,
+                    ,
+                    stdClass::class
+                ),
                 $this->trimnl(TestFailure::exceptionToString($e))
             );
 
@@ -58,12 +61,15 @@ public function testConstraintIsType2(): void
             $constraint->evaluate(new stdClass, 'custom message');
         } catch (ExpectationFailedException $e) {
             $this->assertStringMatchesFormat(
-                <<<'EOF'
+                sprintf(
+                    <<<'EOF'
 custom message
-Failed asserting that stdClass Object #%d () is of type "string".
+Failed asserting that %s Object #%%d () is of type "string".
 
 EOF
                 ,
+                    stdClass::class
+                ),
                 $this->trimnl(TestFailure::exceptionToString($e))
             );
 

diff --git a/tests/unit/Framework/Constraint/ObjectHasAttributeTest.php b/tests/unit/Framework/Constraint/ObjectHasAttributeTest.php
@@ -31,11 +31,14 @@ public function testConstraintObjectHasAttribute(): void
             $constraint->evaluate(new stdClass);
         } catch (ExpectationFailedException $e) {
             $this->assertEquals(
-                <<<'EOF'
-Failed asserting that object of class "stdClass" has attribute "privateAttribute".
+                sprintf(
+                    <<<'EOF'
+Failed asserting that object of class "%s" has attribute "privateAttribute".
 
 EOF
-                ,
+                    ,
+                    stdClass::class
+                ),
                 TestFailure::exceptionToString($e)
             );
 
@@ -53,12 +56,15 @@ public function testConstraintObjectHasAttribute2(): void
             $constraint->evaluate(new stdClass, 'custom message');
         } catch (ExpectationFailedException $e) {
             $this->assertEquals(
-                <<<'EOF'
+                sprintf(
+                    <<<'EOF'
 custom message
-Failed asserting that object of class "stdClass" has attribute "privateAttribute".
+Failed asserting that object of class "%s" has attribute "privateAttribute".
 
 EOF
-                ,
+                    ,
+                    stdClass::class
+                ),
                 TestFailure::exceptionToString($e)
             );