Merge branch '10.5' into 11.0

sebastianbergmann · Mar 12, 2024 · 23e1d9f · 23e1d9f
2 parents 300d85f + d138c06
commit 23e1d9f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/ChangeLog-11.0.md b/ChangeLog-11.0.md
@@ -4,6 +4,18 @@ All notable changes of the PHPUnit 11.0 release series are documented in this fi
 
 ## [11.0.6] - 2024-MM-DD
 
+### Changed
+
+* [#5727](https://github.com/sebastianbergmann/phpunit/pull/5727): Prevent duplicate call of `NamePrettifier::prettifyTestMethodName()`
+* [#5739](https://github.com/sebastianbergmann/phpunit/pull/5739): Micro-optimize `NamePrettifier::prettifyTestMethodName()`
+* [#5740](https://github.com/sebastianbergmann/phpunit/pull/5740): Micro-optimize `TestRunner::runTestWithTimeout()`
+* [#5741](https://github.com/sebastianbergmann/phpunit/pull/5741): Save call to `Telemetry\System::snapshot()`
+* [#5742](https://github.com/sebastianbergmann/phpunit/pull/5742): Prevent file IO when not strictly necessary
+* [#5743](https://github.com/sebastianbergmann/phpunit/pull/5743): Prevent unnecessary `ExecutionOrderDependency::getTarget()` call
+* [#5744](https://github.com/sebastianbergmann/phpunit/pull/5744): Simplify `NamePrettifier::prettifyTestMethodName()`
+
+### Fixed
+
 * [#5351](https://github.com/sebastianbergmann/phpunit/issues/5351): Incorrect code coverage metadata does not prevent code coverage data from being collected
 * [#5729](https://github.com/sebastianbergmann/phpunit/pull/5729): `assertArrayIsIdenticalToArrayOnlyConsideringListOfKeys()` does not correctly handle array order
 

diff --git a/src/Logging/TestDox/NamePrettifier.php b/src/Logging/TestDox/NamePrettifier.php
@@ -27,7 +27,6 @@
 use function is_object;
 use function is_scalar;
 use function method_exists;
-use function ord;
 use function preg_quote;
 use function preg_replace;
 use function range;
@@ -145,9 +144,7 @@ public function prettifyTestMethodName(string $name): string
         $wasNumeric = false;
 
         foreach (range(0, strlen($name) - 1) as $i) {
-            $ord = ord($name[$i]);
-
-            if ($i > 0 && $ord >= 65 && $ord <= 90) {
+            if ($i > 0 && $name[$i] >= 'A' && $name[$i] <= 'Z') {
                 $buffer .= ' ' . strtolower($name[$i]);
             } else {
                 $isNumeric = is_numeric($name[$i]);