Use escapeshellcmd() instead of escapeshellarg() for PHP binary.

sebastianbergmann · Jul 27, 2011 · 45d1f7e · 45d1f7e
1 parent a68b29b
commit 45d1f7e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/PHPUnit/Util/Fileloader.php b/PHPUnit/Util/Fileloader.php
@@ -127,7 +127,7 @@ protected static function syntaxCheck($filename)
         $command = PHPUnit_Util_PHP::getPhpBinary();
 
         if (DIRECTORY_SEPARATOR == '\\') {
-            $command = escapeshellarg($command);
+            $command = escapeshellcmd($command);
         }
 
         $command .= ' -l ' . escapeshellarg($filename);

diff --git a/PHPUnit/Util/PHP.php b/PHPUnit/Util/PHP.php
@@ -109,7 +109,7 @@ public static function getPhpBinary()
             if (!is_readable(self::$phpBinary)) {
                 self::$phpBinary = 'php';
             } else {
-                self::$phpBinary = escapeshellarg(self::$phpBinary);
+                self::$phpBinary = escapeshellcmd(self::$phpBinary);
             }
         }