Cleanup process handling after dropping temp-file handling

sebastianbergmann · Mar 28, 2024 · 51e0bee · 51e0bee
1 parent 500149c
commit 51e0bee
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 33 deletions.
diff --git a/src/Util/PHP/AbstractPhpProcess.php b/src/Util/PHP/AbstractPhpProcess.php
@@ -53,10 +53,6 @@ abstract class AbstractPhpProcess
 
     public static function factory(): self
     {
-        if (PHP_OS_FAMILY === 'Windows') {
-            return new WindowsPhpProcess;
-        }
-
         return new DefaultPhpProcess;
     }
 

diff --git a/src/Util/PHP/DefaultPhpProcess.php b/src/Util/PHP/DefaultPhpProcess.php
@@ -40,7 +40,7 @@ class DefaultPhpProcess extends AbstractPhpProcess
      */
     public function runJob(string $job, array $settings = []): array
     {
-        if ($this->stdin || $this->useTemporaryFile()) {
+        if ($this->stdin) {
             if (!($this->tempFile = tempnam(sys_get_temp_dir(), 'phpunit_')) ||
                 file_put_contents($this->tempFile, $job) === false) {
                 throw new PhpProcessException(
@@ -143,9 +143,4 @@ protected function cleanup(): void
             unlink($this->tempFile);
         }
     }
-
-    protected function useTemporaryFile(): bool
-    {
-        return false;
-    }
 }
diff --git a/src/Util/PHP/WindowsPhpProcess.php b/src/Util/PHP/WindowsPhpProcess.php