Refactor

sebastianbergmann · Jan 24, 2020 · 633898a · 633898a
1 parent a5251f1
commit 633898a
Showing 1 changed file with 55 additions and 21 deletions.
diff --git a/src/Util/Configuration/Extension.php b/src/Util/Configuration/Extension.php
@@ -10,6 +10,8 @@
 namespace PHPUnit\Util\Configuration;
 
 use PHPUnit\Framework\Exception;
+use PHPUnit\Framework\TestListener;
+use PHPUnit\Runner\Hook;
 
 final class Extension
 {
@@ -35,27 +37,6 @@ public function __construct(string $className, string $sourceFile, array $argume
         $this->arguments  = $arguments;
     }
 
-    public function createInstance(): object
-    {
-        $this->ensureClassExists();
-
-        try {
-            $reflector = new \ReflectionClass($this->className);
-        } catch (\ReflectionException $e) {
-            throw new Exception(
-                $e->getMessage(),
-                (int) $e->getCode(),
-                $e
-            );
-        }
-
-        if (!$this->hasArguments()) {
-            return $reflector->newInstance();
-        }
-
-        return $reflector->newInstanceArgs($this->arguments);
-    }
-
     public function className(): string
     {
         return $this->className;
@@ -81,6 +62,59 @@ public function arguments(): array
         return $this->arguments;
     }
 
+    public function createHookInstance(): Hook
+    {
+        $object = $this->createInstance();
+
+        if (!$object instanceof Hook) {
+            throw new Exception(
+                \sprintf(
+                    'Class "%s" does not implement a PHPUnit\Runner\Hook interface',
+                    $this->className
+                )
+            );
+        }
+
+        return $object;
+    }
+
+    public function createTestListenerInstance(): TestListener
+    {
+        $object = $this->createInstance();
+
+        if (!$object instanceof TestListener) {
+            throw new Exception(
+                \sprintf(
+                    'Class "%s" does not implement the PHPUnit\Framework\TestListener interface',
+                    $this->className
+                )
+            );
+        }
+
+        return $object;
+    }
+
+    private function createInstance(): object
+    {
+        $this->ensureClassExists();
+
+        try {
+            $reflector = new \ReflectionClass($this->className);
+        } catch (\ReflectionException $e) {
+            throw new Exception(
+                $e->getMessage(),
+                (int) $e->getCode(),
+                $e
+            );
+        }
+
+        if (!$this->hasArguments()) {
+            return $reflector->newInstance();
+        }
+
+        return $reflector->newInstanceArgs($this->arguments);
+    }
+
     /**
      * @throws Exception
      */