Initial work on event-based result printing

sebastianbergmann · Aug 7, 2022 · 7b7b5dd · 7b7b5dd
1 parent de14574
commit 7b7b5dd
Show file tree

Hide file tree

Showing 26 changed files with 214 additions and 326 deletions.
diff --git a/.psalm/baseline.xml b/.psalm/baseline.xml
@@ -1044,18 +1044,13 @@
     </PropertyNotSetInConstructor>
   </file>
   <file src="src/TextUI/ResultPrinter.php">
-    <DeprecatedClass occurrences="7">
-      <code>LegacyTestResult</code>
-      <code>LegacyTestResult</code>
-      <code>LegacyTestResult</code>
-      <code>LegacyTestResult</code>
-      <code>LegacyTestResult</code>
-      <code>LegacyTestResult</code>
-      <code>LegacyTestResult</code>
-    </DeprecatedClass>
     <MissingThrowsDocblock occurrences="1">
       <code>resourceUsageSinceStartOfRequest</code>
     </MissingThrowsDocblock>
+    <RedundantCondition occurrences="2">
+      <code>assert($test instanceof TestMethod)</code>
+      <code>assert($test instanceof TestMethod)</code>
+    </RedundantCondition>
   </file>
   <file src="src/TextUI/TestRunner.php">
     <DeprecatedClass occurrences="1">

diff --git a/src/Framework/TestSuite.php b/src/Framework/TestSuite.php
@@ -103,18 +103,10 @@ public static function fromClassReflector(ReflectionClass $class): static
         $constructor = $class->getConstructor();
 
         if ($constructor !== null && !$constructor->isPublic()) {
-            $message = sprintf(
-                'Class "%s" has no public constructor.',
-                $class->getName()
-            );
-
-            Event\Facade::emitter()->testRunnerTriggeredWarning($message);
-
-            $testSuite->addTest(
-                new WarningTestCase(
-                    $class->getName(),
-                    '',
-                    $message
+            Event\Facade::emitter()->testRunnerTriggeredWarning(
+                sprintf(
+                    'Class "%s" has no public constructor.',
+                    $class->getName()
                 )
             );
 
@@ -138,18 +130,10 @@ public static function fromClassReflector(ReflectionClass $class): static
         }
 
         if (count($testSuite) === 0) {
-            $message = sprintf(
-                'No tests found in class "%s".',
-                $class->getName()
-            );
-
-            Event\Facade::emitter()->testRunnerTriggeredWarning($message);
-
-            $testSuite->addTest(
-                new WarningTestCase(
-                    $class->getName(),
-                    '',
-                    $message
+            Event\Facade::emitter()->testRunnerTriggeredWarning(
+                sprintf(
+                    'No tests found in class "%s".',
+                    $class->getName()
                 )
             );
         }

diff --git a/src/Runner/TestResult/Collector.php b/src/Runner/TestResult/Collector.php
@@ -235,6 +235,19 @@ public function hasTestMarkedIncompleteEvents(): bool
         return !empty($this->testMarkedIncompleteEvents);
     }
 
+    public function hasTestRunnerTriggeredWarningEvents(): bool
+    {
+        return !empty($this->testRunnerTriggeredWarningEvents);
+    }
+
+    /**
+     * @psalm-return list<TestRunnerWarningTriggered>
+     */
+    public function testRunnerTriggeredWarningEvents(): array
+    {
+        return $this->testRunnerTriggeredWarningEvents;
+    }
+
     /**
      * @psalm-return list<class-string>
      */

diff --git a/src/TextUI/Application.php b/src/TextUI/Application.php
@@ -249,6 +249,15 @@ private function handleArguments(array $argv): TestSuite
             exit(self::EXCEPTION_EXIT);
         }
 
+        if ($testSuite->isEmpty() &&
+            ($arguments->hasArgument() || $this->xmlConfiguration->phpunit()->hasDefaultTestSuite())) {
+            $this->printVersionString();
+
+            print 'No tests found.' . PHP_EOL;
+
+            exit(self::EXCEPTION_EXIT);
+        }
+
         if ($configuration->hasCoverageReport() || $arguments->hasWarmCoverageCache()) {
             CodeCoverageFilterRegistry::init($arguments, $this->xmlConfiguration);
         }