Add type declarations

sebastianbergmann · Dec 15, 2017 · 7e9e3aa · 7e9e3aa
1 parent 7b16723
commit 7e9e3aa
Show file tree

Hide file tree

Showing 11 changed files with 65 additions and 65 deletions.
diff --git a/src/Framework/TestListener.php b/src/Framework/TestListener.php
@@ -21,7 +21,7 @@ interface TestListener
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addError(Test $test, \Throwable $t, $time);
+    public function addError(Test $test, \Throwable $t, float $time): void;
 
     /**
      * A warning occurred.
@@ -30,7 +30,7 @@ public function addError(Test $test, \Throwable $t, $time);
      * @param Warning $e
      * @param float   $time
      */
-    public function addWarning(Test $test, Warning $e, $time);
+    public function addWarning(Test $test, Warning $e, float $time): void;
 
     /**
      * A failure occurred.
@@ -39,7 +39,7 @@ public function addWarning(Test $test, Warning $e, $time);
      * @param AssertionFailedError $e
      * @param float                $time
      */
-    public function addFailure(Test $test, AssertionFailedError $e, $time);
+    public function addFailure(Test $test, AssertionFailedError $e, float $time): void;
 
     /**
      * Incomplete test.
@@ -48,7 +48,7 @@ public function addFailure(Test $test, AssertionFailedError $e, $time);
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addIncompleteTest(Test $test, \Throwable $t, $time);
+    public function addIncompleteTest(Test $test, \Throwable $t, float $time): void;
 
     /**
      * Risky test.
@@ -57,7 +57,7 @@ public function addIncompleteTest(Test $test, \Throwable $t, $time);
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addRiskyTest(Test $test, \Throwable $t, $time);
+    public function addRiskyTest(Test $test, \Throwable $t, float $time): void;
 
     /**
      * Skipped test.
@@ -66,34 +66,34 @@ public function addRiskyTest(Test $test, \Throwable $t, $time);
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addSkippedTest(Test $test, \Throwable $t, $time);
+    public function addSkippedTest(Test $test, \Throwable $t, float $time): void;
 
     /**
      * A test suite started.
      *
      * @param TestSuite $suite
      */
-    public function startTestSuite(TestSuite $suite);
+    public function startTestSuite(TestSuite $suite): void;
 
     /**
      * A test suite ended.
      *
      * @param TestSuite $suite
      */
-    public function endTestSuite(TestSuite $suite);
+    public function endTestSuite(TestSuite $suite): void;
 
     /**
      * A test started.
      *
      * @param Test $test
      */
-    public function startTest(Test $test);
+    public function startTest(Test $test): void;
 
     /**
      * A test ended.
      *
      * @param Test  $test
      * @param float $time
      */
-    public function endTest(Test $test, $time);
+    public function endTest(Test $test, float $time): void;
 }
diff --git a/src/TextUI/ResultPrinter.php b/src/TextUI/ResultPrinter.php
@@ -207,7 +207,7 @@ public function printWaitPrompt(): void
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addError(Test $test, \Throwable $t, $time): void
+    public function addError(Test $test, \Throwable $t, float $time): void
     {
         $this->writeProgressWithColor('fg-red, bold', 'E');
         $this->lastTestFailed = true;
@@ -220,7 +220,7 @@ public function addError(Test $test, \Throwable $t, $time): void
      * @param AssertionFailedError $e
      * @param float                $time
      */
-    public function addFailure(Test $test, AssertionFailedError $e, $time): void
+    public function addFailure(Test $test, AssertionFailedError $e, float $time): void
     {
         $this->writeProgressWithColor('bg-red, fg-white', 'F');
         $this->lastTestFailed = true;
@@ -233,7 +233,7 @@ public function addFailure(Test $test, AssertionFailedError $e, $time): void
      * @param Warning $e
      * @param float   $time
      */
-    public function addWarning(Test $test, Warning $e, $time): void
+    public function addWarning(Test $test, Warning $e, float $time): void
     {
         $this->writeProgressWithColor('fg-yellow, bold', 'W');
         $this->lastTestFailed = true;
@@ -246,7 +246,7 @@ public function addWarning(Test $test, Warning $e, $time): void
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addIncompleteTest(Test $test, \Throwable $t, $time): void
+    public function addIncompleteTest(Test $test, \Throwable $t, float $time): void
     {
         $this->writeProgressWithColor('fg-yellow, bold', 'I');
         $this->lastTestFailed = true;
@@ -259,7 +259,7 @@ public function addIncompleteTest(Test $test, \Throwable $t, $time): void
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addRiskyTest(Test $test, \Throwable $t, $time): void
+    public function addRiskyTest(Test $test, \Throwable $t, float $time): void
     {
         $this->writeProgressWithColor('fg-yellow, bold', 'R');
         $this->lastTestFailed = true;
@@ -272,7 +272,7 @@ public function addRiskyTest(Test $test, \Throwable $t, $time): void
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addSkippedTest(Test $test, \Throwable $t, $time): void
+    public function addSkippedTest(Test $test, \Throwable $t, float $time): void
     {
         $this->writeProgressWithColor('fg-cyan, bold', 'S');
         $this->lastTestFailed = true;
@@ -324,7 +324,7 @@ public function startTest(Test $test): void
      * @param Test  $test
      * @param float $time
      */
-    public function endTest(Test $test, $time): void
+    public function endTest(Test $test, float $time): void
     {
         if ($this->debug) {
             $this->write(

diff --git a/src/Util/Log/JUnit.php b/src/Util/Log/JUnit.php
@@ -138,7 +138,7 @@ public function flush(): void
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addError(Test $test, \Throwable $t, $time): void
+    public function addError(Test $test, \Throwable $t, float $time): void
     {
         $this->doAddFault($test, $t, $time, 'error');
         $this->testSuiteErrors[$this->testSuiteLevel]++;
@@ -151,7 +151,7 @@ public function addError(Test $test, \Throwable $t, $time): void
      * @param Warning $e
      * @param float   $time
      */
-    public function addWarning(Test $test, Warning $e, $time): void
+    public function addWarning(Test $test, Warning $e, float $time): void
     {
         $this->doAddFault($test, $e, $time, 'warning');
         $this->testSuiteFailures[$this->testSuiteLevel]++;
@@ -164,7 +164,7 @@ public function addWarning(Test $test, Warning $e, $time): void
      * @param AssertionFailedError $e
      * @param float                $time
      */
-    public function addFailure(Test $test, AssertionFailedError $e, $time): void
+    public function addFailure(Test $test, AssertionFailedError $e, float $time): void
     {
         $this->doAddFault($test, $e, $time, 'failure');
         $this->testSuiteFailures[$this->testSuiteLevel]++;
@@ -177,7 +177,7 @@ public function addFailure(Test $test, AssertionFailedError $e, $time): void
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addIncompleteTest(Test $test, \Throwable $t, $time): void
+    public function addIncompleteTest(Test $test, \Throwable $t, float $time): void
     {
         $this->doAddSkipped($test);
     }
@@ -189,7 +189,7 @@ public function addIncompleteTest(Test $test, \Throwable $t, $time): void
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addRiskyTest(Test $test, \Throwable $t, $time): void
+    public function addRiskyTest(Test $test, \Throwable $t, float $time): void
     {
         if (!$this->reportUselessTests || $this->currentTestCase === null) {
             return;
@@ -217,7 +217,7 @@ public function addRiskyTest(Test $test, \Throwable $t, $time): void
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addSkippedTest(Test $test, \Throwable $t, $time): void
+    public function addSkippedTest(Test $test, \Throwable $t, float $time): void
     {
         $this->doAddSkipped($test);
     }
@@ -310,8 +310,6 @@ public function endTestSuite(TestSuite $suite): void
      * A test started.
      *
      * @param Test $test
-     *
-     * @throws \ReflectionException
      */
     public function startTest(Test $test): void
     {
@@ -341,7 +339,7 @@ public function startTest(Test $test): void
      * @param Test  $test
      * @param float $time
      */
-    public function endTest(Test $test, $time): void
+    public function endTest(Test $test, float $time): void
     {
         if ($test instanceof TestCase) {
             $numAssertions = $test->getNumAssertions();

diff --git a/src/Util/Log/TeamCity.php b/src/Util/Log/TeamCity.php
@@ -61,7 +61,7 @@ public function printResult(TestResult $result): void
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addError(Test $test, \Throwable $t, $time): void
+    public function addError(Test $test, \Throwable $t, float $time): void
     {
         $this->printEvent(
             'testFailed',
@@ -80,7 +80,7 @@ public function addError(Test $test, \Throwable $t, $time): void
      * @param Warning $e
      * @param float   $time
      */
-    public function addWarning(Test $test, Warning $e, $time): void
+    public function addWarning(Test $test, Warning $e, float $time): void
     {
         $this->printEvent(
             'testFailed',
@@ -99,7 +99,7 @@ public function addWarning(Test $test, Warning $e, $time): void
      * @param AssertionFailedError $e
      * @param float                $time
      */
-    public function addFailure(Test $test, AssertionFailedError $e, $time): void
+    public function addFailure(Test $test, AssertionFailedError $e, float $time): void
     {
         $parameters = [
             'name'    => $test->getName(),
@@ -141,7 +141,7 @@ public function addFailure(Test $test, AssertionFailedError $e, $time): void
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addIncompleteTest(Test $test, \Throwable $t, $time): void
+    public function addIncompleteTest(Test $test, \Throwable $t, float $time): void
     {
         $this->printIgnoredTest($test->getName(), $t);
     }
@@ -153,7 +153,7 @@ public function addIncompleteTest(Test $test, \Throwable $t, $time): void
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addRiskyTest(Test $test, \Throwable $t, $time): void
+    public function addRiskyTest(Test $test, \Throwable $t, float $time): void
     {
         $this->addError($test, $t, $time);
     }
@@ -165,7 +165,7 @@ public function addRiskyTest(Test $test, \Throwable $t, $time): void
      * @param \Throwable $t
      * @param float      $time
      */
-    public function addSkippedTest(Test $test, \Throwable $t, $time): void
+    public function addSkippedTest(Test $test, \Throwable $t, float $time): void
     {
         $testName = $test->getName();
         if ($this->startedTestName !== $testName) {
@@ -193,6 +193,8 @@ public function printIgnoredTest($testName, \Throwable $t): void
      * A testsuite started.
      *
      * @param TestSuite $suite
+     *
+     * @throws \ReflectionException
      */
     public function startTestSuite(TestSuite $suite): void
     {
@@ -265,6 +267,8 @@ public function endTestSuite(TestSuite $suite): void
      * A test started.
      *
      * @param Test $test
+     *
+     * @throws \ReflectionException
      */
     public function startTest(Test $test): void
     {
@@ -287,7 +291,7 @@ public function startTest(Test $test): void
      * @param Test  $test
      * @param float $time
      */
-    public function endTest(Test $test, $time): void
+    public function endTest(Test $test, float $time): void
     {
         parent::endTest($test, $time);
 

diff --git a/src/Util/TestDox/CliTestDoxPrinter.php b/src/Util/TestDox/CliTestDoxPrinter.php
@@ -92,7 +92,7 @@ function (string $color, string $buffer) {
         parent::startTest($test);
     }
 
-    public function endTest(Test $test, $time): void
+    public function endTest(Test $test, float $time): void
     {
         if (!$test instanceof TestCase && !$test instanceof PhptTestCase) {
             return;
@@ -111,31 +111,31 @@ public function endTest(Test $test, $time): void
         }
     }
 
-    public function addError(Test $test, \Throwable $t, $time): void
+    public function addError(Test $test, \Throwable $t, float $time): void
     {
         $this->currentTestResult->fail(
             $this->formatWithColor('fg-yellow', '✘'),
             (string) $t
         );
     }
 
-    public function addWarning(Test $test, Warning $e, $time): void
+    public function addWarning(Test $test, Warning $e, float $time): void
     {
         $this->currentTestResult->fail(
             $this->formatWithColor('fg-yellow', '✘'),
             (string) $e
         );
     }
 
-    public function addFailure(Test $test, AssertionFailedError $e, $time): void
+    public function addFailure(Test $test, AssertionFailedError $e, float $time): void
     {
         $this->currentTestResult->fail(
             $this->formatWithColor('fg-red', '✘'),
             (string) $e
         );
     }
 
-    public function addIncompleteTest(Test $test, \Throwable $t, $time): void
+    public function addIncompleteTest(Test $test, \Throwable $t, float $time): void
     {
         $this->currentTestResult->fail(
             $this->formatWithColor('fg-yellow', '∅'),
@@ -144,7 +144,7 @@ public function addIncompleteTest(Test $test, \Throwable $t, $time): void
         );
     }
 
-    public function addRiskyTest(Test $test, \Throwable $t, $time): void
+    public function addRiskyTest(Test $test, \Throwable $t, float $time): void
     {
         $this->currentTestResult->fail(
             $this->formatWithColor('fg-yellow', '☢'),
@@ -153,11 +153,11 @@ public function addRiskyTest(Test $test, \Throwable $t, $time): void
         );
     }
 
-    public function addSkippedTest(Test $test, \Throwable $e, $time): void
+    public function addSkippedTest(Test $test, \Throwable $t, float $time): void
     {
         $this->currentTestResult->fail(
             $this->formatWithColor('fg-yellow', '→'),
-            (string) $e,
+            (string) $t,
             true
         );
     }