refactor: Use closure for no-op error handlers

Co-authored-by: Michael Voříšek <mvorisek@mvorisek.cz> Signed-off-by: Natsuki Ikeguchi <me@s6n.jp>
sebastianbergmann · Jan 23, 2024 · a5f3908 · a5f3908
1 parent 9dacf83
commit a5f3908
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/Util/PHP/Template/TestCaseClass.tpl b/src/Util/PHP/Template/TestCaseClass.tpl
@@ -66,7 +66,7 @@ function __phpunit_run_isolated_test()
 
     ini_set('xdebug.scream', '0');
 
-    set_error_handler('__phpunit_error_handler');
+    set_error_handler(static fn() => false);
 
     // Not every STDOUT target stream is rewindable
     @rewind(STDOUT);

diff --git a/src/Util/PHP/Template/TestCaseMethod.tpl b/src/Util/PHP/Template/TestCaseMethod.tpl
@@ -31,11 +31,6 @@ if ($composerAutoload) {
     require $phar;
 }
 
-function __phpunit_error_handler($errno, $errstr, $errfile, $errline)
-{
-   return true;
-}
-
 function __phpunit_run_isolated_test()
 {
     $dispatcher = Facade::instance()->initForIsolation(
@@ -71,7 +66,7 @@ function __phpunit_run_isolated_test()
 
     ini_set('xdebug.scream', '0');
 
-    set_error_handler('__phpunit_error_handler');
+    set_error_handler(static fn() => false);
 
     // Not every STDOUT target stream is rewindable
     @rewind(STDOUT);
@@ -103,6 +98,11 @@ function __phpunit_run_isolated_test()
     );
 }
 
+function __phpunit_error_handler($errno, $errstr, $errfile, $errline)
+{
+    return true;
+}
+
 set_error_handler('__phpunit_error_handler');
 
 {constants}