Do not pass null to ReflectionClass::getMethods()

sebastianbergmann · Jul 29, 2022 · b276edb · b276edb
1 parent 9edbd2e
commit b276edb
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/Util/Reflection.php b/src/Util/Reflection.php
@@ -42,7 +42,11 @@ private function filterMethods(ReflectionClass $class, ?int $filter): array
     {
         $methods = [];
 
-        foreach ($class->getMethods($filter) as $method) {
+        // PHP <7.2.18 and <7.3.5 throw error when null is passed
+        // to ReflectionClass::getMethods() when strict_types is enabled.
+        $classMethods = $filter === null ? $class->getMethods() : $class->getMethods($filter);
+
+        foreach ($classMethods as $method) {
             if ($method->getDeclaringClass()->getName() === TestCase::class) {
                 continue;
             }