Improve selection of garbage collector status provider

sebastianbergmann · Apr 20, 2023 · e62c274 · e62c274
1 parent 0a012a2
commit e62c274
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.psalm/baseline.xml b/.psalm/baseline.xml
@@ -49,6 +49,9 @@
     <ArgumentTypeCoercion>
       <code><![CDATA[$eventClass . 'Subscriber']]></code>
     </ArgumentTypeCoercion>
+    <InvalidArrayOffset>
+      <code><![CDATA[gc_status()['running']]]></code>
+    </InvalidArrayOffset>
   </file>
   <file src="src/Event/Value/Runtime/PHP.php">
     <ImpureFunctionCall>

diff --git a/src/Event/Facade.php b/src/Event/Facade.php
@@ -9,7 +9,7 @@
  */
 namespace PHPUnit\Event;
 
-use function version_compare;
+use function gc_status;
 use PHPUnit\Event\Telemetry\HRTime;
 use PHPUnit\Event\Telemetry\Php81GarbageCollectorStatusProvider;
 use PHPUnit\Event\Telemetry\Php83GarbageCollectorStatusProvider;
@@ -247,7 +247,7 @@ private function registerDefaultTypes(TypeMap $typeMap): void
 
     private function garbageCollectorStatusProvider(): Telemetry\GarbageCollectorStatusProvider
     {
-        if (version_compare('8.3.0', PHP_VERSION, '>')) {
+        if (!isset(gc_status()['running'])) {
             return new Php81GarbageCollectorStatusProvider;
         }