Use foreach() instead of for(). Fixes #30.

sebastianbergmann · Aug 2, 2006 · ed72901 · ed72901
1 parent ff8ec1a
commit ed72901
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/PHPUnit/Framework/TestResult.php b/PHPUnit/Framework/TestResult.php
@@ -151,11 +151,9 @@ public function addListener(PHPUnit_Framework_TestListener $listener)
      */
     public function removeListener(PHPUnit_Framework_TestListener $listener)
     {
-        $max = count($this->listeners);
-
-        for ($i = 0; $i < $max; $i++) {
-            if ($this->listeners[$i] === $listener) {
-                unset($this->listeners[$i]);
+        foreach ($this->listeners as $key => $_listener) {
+            if ($listener === $_listener) {
+                unset($this->listeners[$key]);
             }
         }
     }

diff --git a/PHPUnit/Util/Filter.php b/PHPUnit/Util/Filter.php
@@ -128,11 +128,10 @@ public static function removeFileFromFilter($filename, $group = 'DEFAULT')
     {
         if (isset(self::$filteredFiles[$group])) {
             $filename = self::getCanonicalFilename($filename);
-            $max      = count(self::$filteredFiles[$group]);
 
-            for ($i = 0; $i < $max; $i++) {
-                if (self::$filteredFiles[$group][$i] == $filename) {
-                    unset(self::$filteredFiles[$group][$i]);
+            foreach (self::$filteredFiles[$group] as $key => $_filename) {
+                if ($filename == $_filename) {
+                    unset(self::$filteredFiles[$group][$key]);
                 }
             }
         }