Skip to content

Commit

Permalink
Fix TRAC-979.
Browse files Browse the repository at this point in the history
  • Loading branch information
sebastianbergmann committed Jan 7, 2010
1 parent b1f68cf commit f64e76d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
6 changes: 2 additions & 4 deletions PHPUnit/Util/Report/Node/File.php
Expand Up @@ -270,13 +270,11 @@ public function render($target, $title, $charset = 'ISO-8859-1', $lowUpperBound
$ignore = FALSE;

foreach ($this->codeLines as $line) {

This comment has been minimized.

Copy link
@avadhutp

avadhutp Apr 15, 2010

Why doesn't this generate the clover report properly then? With the --coverag-clover option? The lines are still counted.

$trimmedLine = trim($line);

if ($trimmedLine == '// @codeCoverageIgnoreStart') {
if (strpos($line, '@codeCoverageIgnoreStart') !== FALSE) {
$ignore = TRUE;
}

else if ($trimmedLine == '// @codeCoverageIgnoreEnd') {
else if (strpos($line, '@codeCoverageIgnoreEnd') !== FALSE) {
$ignore = FALSE;
}

Expand Down
5 changes: 5 additions & 0 deletions README.markdown
Expand Up @@ -3,6 +3,11 @@ PHPUnit 3.4

This is the list of changes for the PHPUnit 3.4 release series.

PHPUnit 3.4.7
-------------

* Fixed TRAC-979: `@codeCoverageIgnoreStart` is being ignored.

PHPUnit 3.4.6
-------------

Expand Down

1 comment on commit f64e76d

@avadhutp
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why doesn't this generate the clover report properly then? With the --coverag-clover option? The lines are still counted.

Please sign in to comment.