New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'uses' and 'covers' should only take a single word #1857

Closed
KingCrunch opened this Issue Sep 16, 2015 · 3 comments

Comments

3 participants
@KingCrunch

KingCrunch commented Sep 16, 2015

I'd like to comment, why it's OK for a test to @uses a different class, or method like

/**
 * @uses Foo\Bar This is a value object
 */

This fails with

Trying to @cover or @use not existing class or interface "Foo\Bar This is a value object".

Because it is not possible to refer to a class, or method with a whitespace PHPUnit should only take the first word after the annotation and should leave everything else as a comment

@sebastianbergmann

This comment has been minimized.

Owner

sebastianbergmann commented Sep 16, 2015

Makes sense to me. I'll gladly accept a pull request that adapts the respective regular expressions.

@KingCrunch

This comment has been minimized.

KingCrunch commented Oct 5, 2015

@dstockto Thanks :)

@dstockto

This comment has been minimized.

dstockto commented Oct 5, 2015

@KingCrunch No problem. I hope I didn't break anything :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment