Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove assertions that operate on class/object properties #4602

Closed
sebastianbergmann opened this issue Feb 9, 2021 · 3 comments
Closed

Remove assertions that operate on class/object properties #4602

sebastianbergmann opened this issue Feb 9, 2021 · 3 comments
Assignees
@sebastianbergmann
Labels
feature/assertion Issues related to assertions and expectations type/backward-compatibility Something will be/is intentionally broken
Milestone
PHPUnit 10.0

Comments

@sebastianbergmann
Copy link
Owner

sebastianbergmann commented Feb 9, 2021 •
edited

The following methods of PHPUnit\Framework\Assert will be removed in PHPUnit 11:

  • assertClassHasAttribute()
  • assertClassNotHasAttribute()
  • assertClassHasStaticAttribute()
  • assertClassNotHasStaticAttribute()
  • assertObjectHasAttribute()
  • assertObjectNotHasAttribute()
  • classHasAttribute()
  • classHasStaticAttribute()
  • objectHasAttribute()

The following classes will be removed in PHPUnit 11:

  • PHPUnit\Framework\Constraint\ClassHasAttribute
  • PHPUnit\Framework\Constraint\ClassHasStaticAttribute
  • PHPUnit\Framework\Constraint\ObjectHasAttribute

This follows #4601.
@sebastianbergmann sebastianbergmann added type/backward-compatibility Something will be/is intentionally broken feature/assertion Issues related to assertions and expectations labels Feb 9, 2021
@sebastianbergmann sebastianbergmann added this to the PHPUnit 11.0 milestone Feb 9, 2021
@sebastianbergmann sebastianbergmann self-assigned this Feb 9, 2021
@sebastianbergmann sebastianbergmann mentioned this issue Feb 9, 2021
Closed
@jrfnl
Copy link
Contributor

jrfnl commented Jun 9, 2021

Just checking: is the "PHPUnit 10" in the above issue correct or should this be "PHPUnit 11" ?

@sebastianbergmann
Copy link
Owner Author

Just checking: is the "PHPUnit 10" in the above issue correct or should this be "PHPUnit 11" ?

Thank you for pointing this out. I have updated the issue to say "PHPUnit 11".

@sebastianbergmann
Copy link
Owner Author

Moved forward to PHPUnit 10.

@verfriemelt-dot-org verfriemelt-dot-org mentioned this issue Feb 3, 2023
Closed
@LordSimal LordSimal mentioned this issue Feb 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
feature/assertion Issues related to assertions and expectations type/backward-compatibility Something will be/is intentionally broken
Projects
None yet
Milestone
PHPUnit 10.0
Development

No branches or pull requests
2 participants
@sebastianbergmann @jrfnl