You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running tests from PHPSTORM, before PHPUnit 8.5.15, having failOnWarning="true", test with warnings was marked as failed, now it's marked as passed.
Current behavior
Tests with warnings marked as passed in PHPSTORM
How to reproduce
Create test.
Make mistake in dataprovider method or in setUp e.g. try to configure a method that does not exist in mocked class
Run test
Test marked as passed
Expected behavior
Having failOnWarning="true" -> tests with a warning should be marked as failed
But there must be some other solution.
Why is it important? With just one mistake in the seUp() method (e.g. ->method('not_existed_method') ), all tests inside the class will not be executed, but will be marked as "passed" - obviously this is not what is expected.
If I remove method from class, I expect that tests, where such method was configured, will fail
The text was updated successfully, but these errors were encountered:
Summary
Was introduced here #4623
Running tests from PHPSTORM, before PHPUnit 8.5.15, having failOnWarning="true", test with warnings was marked as failed, now it's marked as passed.
Current behavior
Tests with warnings marked as passed in PHPSTORM
How to reproduce
Create test.
Make mistake in dataprovider method or in setUp e.g. try to configure a method that does not exist in mocked class
Run test
Test marked as passed
Expected behavior
Having failOnWarning="true" -> tests with a warning should be marked as failed
I understand there were some reasons for #4623
But there must be some other solution.
Why is it important? With just one mistake in the seUp() method (e.g. ->method('not_existed_method') ), all tests inside the class will not be executed, but will be marked as "passed" - obviously this is not what is expected.
If I remove method from class, I expect that tests, where such method was configured, will fail
The text was updated successfully, but these errors were encountered: