Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process-isolation causes Notice #710

Closed
m6w6 opened this issue Nov 8, 2012 · 10 comments
Closed

process-isolation causes Notice #710

m6w6 opened this issue Nov 8, 2012 · 10 comments

Comments

@m6w6
Copy link

m6w6 commented Nov 8, 2012

Notice: Undefined variable: time in /usr/share/pear/PHPUnit/Util/PHP.php on line 296

$ phpunit --version
PHPUnit 3.7.9 by Sebastian Bergmann.

@edorian
Copy link
Sponsor Contributor

edorian commented Nov 12, 2012

Thanks for the report but I don't really see how this can happen.

Do you overwrite phpunits custom error handler with a custom set_error_handler call?

If not I can't reproduce this and would need a sample

@DennisBecker
Copy link

I've got the same error when I use @runInSeperateProcess annotation for a test and also using --process-isolation.

phpunit --version
PHPUnit 3.7.10 by Sebastian Bergmann.

PHP version 5.3.10 on Ubuntu 12.04

@edorian
Copy link
Sponsor Contributor

edorian commented Jan 4, 2013

Like i said. Can't reproduce. Not with 5.4, nor with 5.3 with PHPUnit 3.6.12, 3.7.10 and dev versions.

So if anyone has a reproduce case/enviornment for this I'd gladly take it.

Just some random test cases with --process-isolation just work out for me.

@edorian edorian closed this as completed Jan 4, 2013
@m6w6
Copy link
Author

m6w6 commented Jan 4, 2013

@edorian
Copy link
Sponsor Contributor

edorian commented Jan 4, 2013

Would have been easier If I'd knew how to run the test and that I had to install the extension but I figured it out and there it fails.

Can reproduce now. Thanks a bunch

@edorian
Copy link
Sponsor Contributor

edorian commented Jan 4, 2013

So unserialize there returns "false" but no E_NOTICE is issued.

This, apparently, happens when $stdout is an empty string.

I'm not really sure why the child result is empty in that case or if that is acceptable behavior. Any input @sebastianbergmann ?

@emil-nasso
Copy link

I can confirm this issue on phpunit 3.7.10 .

Should this issue not be open?

@edorian
Copy link
Sponsor Contributor

edorian commented Jan 8, 2013

I've closed this because I didn't have a reproduce case. When i got one i forgot to reopen it.

@emil-nasso If you have short reproduce has for this (that doesn't require compiling an extension) I'd gladly take it to add it to the regression suite :)

@edorian edorian reopened this Jan 8, 2013
@whatthejeff
Copy link
Contributor

I can reproduce this by setting display_errors = Off and log_errors = Off in php.ini and running the Tests/TextUI/fatal-isolation.phpt test included with PHPUnit.

@whatthejeff whatthejeff mentioned this issue Jan 13, 2013
@whatthejeff
Copy link
Contributor

I think this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants