Fixed multiple backslash global with @runTestsInSeparateProcesses and @preserveGlobalState #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… @preserveGlobalState
|
Thanks, @shabbyrobe! |
|
Don't worry about the travis/composer issues. There seems to be some outstanding DNS issues (see https://twitter.com/whatthejeff/status/490539661878886401). I tried to rerun the tests a few times to no avail. I'll try again in a few hours. |
|
Yay, it worked after a few more restarts. Thanks again, @shabbyrobe :) |
whatthejeff
added a commit
that referenced
this pull request
Jul 21, 2014
Fixed multiple backslash global with @runTestsInSeparateProcesses and @preserveGlobalState
|
Cool, thanks! Would you prefer me to start an issue and discussing before fixing bugs in future? |
|
Yeah–if it's a bug that will have regression tests, it helps to have an existing issue to reference. Thanks again for your contributions :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of #1335 using 4.1 branch and regression test instead of private method test