Implementation for assertArraySubset #1371 #1377
Conversation
| * @param array|ArrayAccess $partial | ||
| * @param array|ArrayAccess $array | ||
| * @param string $message | ||
| * @since Method available since Release 4.0.2 |
There was a problem hiding this comment.
This will be available in 4.3.0 (granted we get it merged in the next couple of days :P)
There was a problem hiding this comment.
Let's actually do 4.4.0 since 4.3.0 is going into beta soon.
There was a problem hiding this comment.
Oh no, I've just pushed with 4.3.0
|
Thanks, will push corrections ASAP ;) |
|
Thanks, @marcioAlmada :) |
|
ok, all set. |
marcioAlmada
changed the title
| function assertSubset($subset, $array, $strict = false, $message = '') | ||
| { | ||
| return call_user_func_array( | ||
| 'PHPUnit_Framework_Assert::assertArrayPart', |
There was a problem hiding this comment.
Oops. It seems phpunit functional api is not being tested... would be nice to run all tests against the functional API too...
There was a problem hiding this comment.
@whatthejeff ok, I've just made a forced push with the fix so we don't pollute the commit history.
There was a problem hiding this comment.
@marcioAlmada Alright, I should have time to review/merge this later today. Thanks :)
marcioAlmada
changed the title
fix code style
bump `@since` tag from 4.3.0 to 4.4.0, as defined in #1377 (comment)
Implementation for assertArraySubset #1371
|
Thanks for all your hard work, @marcioAlmada! |
|
And thank you for being an attentious maintainer :) |
I probably will not have time to open this PR later this weekend so I decided to do it now, just in case the feature discussed at #1371 get's approved :D
In case it gets approved but with a different assertion name I'll be happy to update the PR, just ping me.
Cheers.