Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #2431 - ArrayAccess support missing in assertArraySubset #2438

Closed
wants to merge 2 commits into from

Conversation

exts
Copy link
Contributor

@exts exts commented Jan 24, 2017

Fixes #2431 - Added ArrayAccess support to assertArraySubset

@exts
Copy link
Contributor Author

exts commented Jan 24, 2017

Looks like you can close #2108 as well.

@sebastianbergmann
Copy link
Owner

Merged manually, thanks.

@exts
Copy link
Contributor Author

exts commented Mar 9, 2017

@nisevi looking at your error in the last message: This issue fixes a specific issue which gives support for ArrayAccess in assertArraySubset()

Your error has to do with laravel passing an empty value to the assertArrayHasKey() which is a completely different function.

After doing some digging, create an issue over on the laravel github with your issue and refer to this block of code

@nisevi
Copy link

nisevi commented Mar 9, 2017

Hey @exts sorry I deleted my comment since I thought I was doing something wrong, and I didn't want to bother. Cool I will create an issue on the Laravel repository.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants