[4.8] Avoid using function each() #2773
Conversation
Backport of 48930fc by @eclipxe13
|
cherry-pick of that commit didn't work? |
|
I think other commit is missing, the full PR is about 4 commits, 2 of tests and 2 of code. |
|
maybe try picking the 4? having the tests would be nice in this branch as well I guess :) |
|
@eclipxe13 You are right! @SpacePossum I manually rewrote the 4th commit, cherry picked the two commits for tests, and fixed the tests for older PHP and PHPUnit |
tests/Util/GetoptTest.php
Outdated
|
|
||
| public function testItHandlesLongParametesWithValues() | ||
| { | ||
| $command = 'command parameter-0 --exec parameter-1 --conf config.xml --optn parameter-2 --optn=content-of-o parameter-n'; |
There was a problem hiding this comment.
Line exceeds 120 characters; contains 129 characters
I had a merge conflict, so I preferred to rewrite it by hand |
|
Yes please, that would fix the build for the legacy version of concrete5 https://github.com/concrete5/concrete5-legacy/ |
|
PHPUnit 4.8 is no longer supported (and never supported PHP 7). |
|
@sebastianbergmann We need to test a software that supports PHP from version 5.3 to 7.2 (dropping end-of-life PHP versions is not an option for us). Do you have any suggestion about how could we do that? |
|
You could always fork your preferred version of PHPUnit and maintain it yourself since no new commits will be put in the upstream one. |
|
@hboomsma thanks for the feedback. I already know we can fork phpunit, but I was wondering if @sebastianbergmann had a better approach, since I think we are not the only one with this need... |
Backport of 48930fc by @eclipxe13 to the 4.8 series