Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpdoc on createMock() #2963

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Fix phpdoc on createMock() #2963

merged 1 commit into from
Jan 16, 2018

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Jan 15, 2018

Hi,

This fixes an error raised by phpstan (static analysis)

Parameter 1 $originalClassName of method PHPUnit\Framework\TestCase::createMock() expects string, array<int, string> given.

And can be traced back to https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/TestCase.php#L1198

@codecov-io
Copy link

codecov-io commented Jan 15, 2018

Codecov Report

Merging #2963 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2963   +/-   ##
=========================================
  Coverage     80.32%   80.32%           
  Complexity     2816     2816           
=========================================
  Files           107      107           
  Lines          7429     7429           
=========================================
  Hits           5967     5967           
  Misses         1462     1462
Impacted Files Coverage Δ Complexity Δ
src/Framework/TestCase.php 66.46% <ø> (ø) 309 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eae3fa3...0bcbff5. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit c74a5dd into sebastianbergmann:master Jan 16, 2018
@ro0NL ro0NL deleted the patch-1 branch January 16, 2018 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants