Strip of remaining s\ when TestDox classname starts with Tests\ #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3028 +/- ##
============================================
+ Coverage 80.72% 80.73% +<.01%
- Complexity 2877 2878 +1
============================================
Files 108 108
Lines 7535 7537 +2
============================================
+ Hits 6083 6085 +2
Misses 1452 1452
Continue to review full report at Codecov.
|
|
Hi @sebastianbergmann, would you mind explaining why you closed this pull-request? |
|
It was merged. |
|
Apologies, I didn't see that. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of projects, including for example Laravel, start their test classes with the Tests namespace.
When using TestDox our testclass is reported with a leading s\.
Look at the example below.
This commit fixes that.