Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExceptionMessage constraint strict, expectedException can handle only expected class, not message nor code - for 7.4 line #3343

Conversation

keradus
Copy link
Contributor

@keradus keradus commented Oct 11, 2018

#3326 for 7.4 line

as requested by @sebastianbergmann in #3326 (comment)

@codecov-io
Copy link

codecov-io commented Oct 11, 2018

Codecov Report

Merging #3343 into 7.4 will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##                7.4   #3343      +/-   ##
===========================================
- Coverage     82.61%   82.6%   -0.02%     
+ Complexity     3533    3530       -3     
===========================================
  Files           143     143              
  Lines          9331    9325       -6     
===========================================
- Hits           7709    7703       -6     
  Misses         1622    1622
Impacted Files Coverage Δ Complexity Δ
src/Util/Test.php 93.68% <100%> (-0.05%) 218 <0> (-2)
src/Framework/Constraint/ExceptionMessage.php 77.77% <66.66%> (-2.23%) 6 <0> (-1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5015bff...01fd6a2. Read the comment docs.

@keradus
Copy link
Contributor Author

keradus commented Dec 9, 2018

@sebastianbergmann , you asked me to raise this PR against 7.4 branch, now branch does no longer exist, shall I raise a PR for 7.5 ?

@sebastianbergmann
Copy link
Owner

No, since the pull request for 6.5 was reverted. See #3325 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants