Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let AfterTestHook extend TestHook instead of Hook #3762

Merged
merged 1 commit into from Jul 30, 2019
Merged

Let AfterTestHook extend TestHook instead of Hook #3762

merged 1 commit into from Jul 30, 2019

Conversation

dontub
Copy link
Contributor

@dontub dontub commented Jul 24, 2019

AfterTestHook has to extend TestHook instead of Hook to be added to the TestListenerAdapter, otherwise executeAfterTest() is never called.

@dontub
Let AfterTestHook extend TestHook instead of Hook
281e477 
`AfterTestHook` has to extend `TestHook` instead of `Hook` to be added to the `TestListenerAdapter`, otherwise `executeAfterTest()` is never called.
@codecov
Copy link

codecov bot commented Jul 24, 2019 •
edited

Codecov Report

Merging #3762 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3762   +/-   ##
=========================================
  Coverage     82.38%   82.38%           
  Complexity     3802     3802           
=========================================
  Files           150      150           
  Lines         10054    10054           
=========================================
  Hits           8283     8283           
  Misses         1771     1771

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac90ad...281e477. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit 1c015f5 into sebastianbergmann:master Jul 30, 2019
@sebastianbergmann sebastianbergmann self-assigned this Jul 30, 2019
@sebastianbergmann sebastianbergmann added the type/bug Something is broken label Jul 30, 2019
@sebastianbergmann sebastianbergmann added this to the PHPUnit 8.3 milestone Jul 30, 2019
@localheinz localheinz mentioned this pull request Dec 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sebastianbergmann sebastianbergmann

Labels
type/bug Something is broken
Projects
None yet
Milestone
PHPUnit 8.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dontub @sebastianbergmann