Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and small refactorings #3830

Conversation

realFlowControl
Copy link
Sponsor Contributor

@realFlowControl realFlowControl commented Sep 7, 2019

This pull request does

  • some small cleanups
  • group code together, that belongs together for easier understanding
  • enforce check on class name in file when called via phpunit classTest path/to/classTest.php

... and nevermind the branch name 馃槈

@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

Merging #3830 into master will increase coverage by 0.14%.
The diff coverage is 82.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3830      +/-   ##
============================================
+ Coverage     82.81%   82.96%   +0.14%     
+ Complexity     3843     3826      -17     
============================================
  Files           151      151              
  Lines         10168    10136      -32     
============================================
- Hits           8421     8409      -12     
+ Misses         1747     1727      -20
Impacted Files Coverage 螖 Complexity 螖
src/TextUI/Command.php 75.04% <100%> (+0.08%) 212 <0> (酶) 猬囷笍
src/Runner/StandardTestSuiteLoader.php 62.5% <76.19%> (+11.73%) 9 <0> (-17) 猬囷笍
src/Framework/TestSuiteIterator.php 100% <0%> (酶) 11% <0%> (酶) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 5a44f11...8d85536. Read the comment docs.

@realFlowControl realFlowControl force-pushed the accept-a-list-of-testfiles branch 3 times, most recently from 0ec573e to 09ae16c Compare September 7, 2019 11:04
@realFlowControl realFlowControl marked this pull request as ready for review September 7, 2019 12:33
@sebastianbergmann sebastianbergmann merged commit 4f53bc1 into sebastianbergmann:master Sep 7, 2019
@sebastianbergmann sebastianbergmann added the event/code-sprint/2019-09 PHPUnit Code Sprint: September 2019 label Sep 7, 2019
@realFlowControl realFlowControl deleted the accept-a-list-of-testfiles branch September 7, 2019 13:03
@realFlowControl realFlowControl mentioned this pull request Oct 10, 2019
realFlowControl added a commit to realFlowControl/phpunit that referenced this pull request Oct 30, 2019
realFlowControl added a commit to realFlowControl/phpunit that referenced this pull request Oct 30, 2019
realFlowControl added a commit to realFlowControl/phpunit that referenced this pull request Oct 30, 2019
realFlowControl added a commit to realFlowControl/phpunit that referenced this pull request Oct 31, 2019
sebastianbergmann pushed a commit that referenced this pull request Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event/code-sprint/2019-09 PHPUnit Code Sprint: September 2019
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants