Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertRegExp #4217

Conversation

mitch292
Copy link

Resolves #4087

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #4217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4217   +/-   ##
=========================================
  Coverage     84.15%   84.15%           
  Complexity     4523     4523           
=========================================
  Files           219      219           
  Lines         11099    11099           
=========================================
  Hits           9340     9340           
  Misses         1759     1759           
Impacted Files Coverage Δ Complexity Δ
src/Framework/Assert.php 93.74% <ø> (ø) 223.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d76f22...72e6f9a. Read the comment docs.

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it as this has to wait until after the release of PHPUnit 9.5 and I do not want to have to keep this pull request in sync until then. In the future, please do not start to work on issues such as #4087 that have an assignee.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove assertRegExp()
2 participants