Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence stream_get_contents() warnings in TestCaseClass.tpl and TestCaseMethod.tpl #4486

Merged
merged 1 commit into from Oct 22, 2020

Conversation

sanmai
Copy link
Contributor

@sanmai sanmai commented Oct 22, 2020

Although this problem is typically seen with PHPDBG, as per #3965, and not with regular PHP, it is not PHPDBG specific:

php -r 'stream_get_contents(STDOUT);' | cat

Will output the same error on PHP 7.4.11:

PHP Notice:  stream_get_contents(): read of 8192 bytes failed with errno=9 Bad file descriptor in Command line code on line 1
PHP Stack trace:
PHP   1. {main}() Command line code:0
PHP   2. stream_get_contents() Command line code:1

This problem first appeared in PHP 7.4.0.

Fixes #3965

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #4486 into 8.5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                8.5    #4486   +/-   ##
=========================================
  Coverage     84.31%   84.31%           
  Complexity     3938     3938           
=========================================
  Files           154      154           
  Lines          9789     9789           
=========================================
  Hits           8254     8254           
  Misses         1535     1535           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ac24d...3bd5abb. Read the comment docs.

@sebastianbergmann
Copy link
Owner

Please make this against 8.5. Thanks!

@sanmai sanmai changed the base branch from master to 8.5 October 22, 2020 05:09
@sanmai
Copy link
Contributor Author

sanmai commented Oct 22, 2020

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process isolation under phpdbg throws exceptions
2 participants