Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for case insensitive class names #4498 #4499

Conversation

realFlowControl
Copy link
Sponsor Contributor

Hey there 馃枛

this PR fixes #4498 by adding support for case insensitive namespaced class names when calling PHPUnit with the test case file name.

/Flo

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #4499 into 9.4 will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                9.4    #4499      +/-   ##
============================================
- Coverage     84.65%   84.65%   -0.01%     
+ Complexity     4586     4585       -1     
============================================
  Files           251      251              
  Lines         11875    11874       -1     
============================================
- Hits          10053    10052       -1     
  Misses         1822     1822              
Impacted Files Coverage 螖 Complexity 螖
src/Runner/StandardTestSuiteLoader.php 87.50% <100.00%> (-0.38%) 17.00 <0.00> (-1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ce0a3a1...dd2ddc9. Read the comment docs.

@realFlowControl realFlowControl force-pushed the allow-for-case-insensitive-class-names-4498 branch 2 times, most recently from 81ed566 to f739dcb Compare October 28, 2020 10:21
@sebastianbergmann
Copy link
Owner

Can you send this against 9.4, please? Thanks!

@realFlowControl realFlowControl force-pushed the allow-for-case-insensitive-class-names-4498 branch from f739dcb to 4022f31 Compare October 28, 2020 10:53
@realFlowControl realFlowControl force-pushed the allow-for-case-insensitive-class-names-4498 branch from 4022f31 to dd2ddc9 Compare October 28, 2020 10:55
@realFlowControl realFlowControl changed the base branch from master to 9.4 October 28, 2020 10:55
@realFlowControl
Copy link
Sponsor Contributor Author

@sebastianbergmann rebased onto 9.4 and changed the base branch

@realFlowControl
Copy link
Sponsor Contributor Author

IDK why codecov is failing 馃槥

@sebastianbergmann sebastianbergmann merged commit 356d444 into sebastianbergmann:9.4 Oct 29, 2020
@realFlowControl realFlowControl deleted the allow-for-case-insensitive-class-names-4498 branch October 29, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please make the class matching case insenstive
2 participants