Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use short array syntax #4585

Closed
wants to merge 1 commit into from

Conversation

localheinz
Copy link
Collaborator

This PR

  • uses short array syntax

@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #4585 (a355905) into master (4f1f6e2) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4585      +/-   ##
============================================
- Coverage     83.55%   83.39%   -0.16%     
  Complexity     4553     4553              
============================================
  Files           286      286              
  Lines         11759    11759              
============================================
- Hits           9825     9807      -18     
- Misses         1934     1952      +18     
Impacted Files Coverage Δ Complexity Δ
src/Util/PHP/WindowsPhpProcess.php 0.00% <0.00%> (-81.82%) 5.00% <0.00%> (ø%)
src/Util/PHP/DefaultPhpProcess.php 43.95% <0.00%> (-7.70%) 33.00% <0.00%> (ø%)
src/Util/ExcludeList.php 65.51% <0.00%> (-3.45%) 14.00% <0.00%> (ø%)
src/Util/PHP/AbstractPhpProcess.php 73.97% <0.00%> (-0.69%) 44.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1f6e2...a355905. Read the comment docs.

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it because this file is supposed to still work with PHP 5.3 (maybe older).

@localheinz localheinz deleted the fix/short branch January 15, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants