Remove strict incomplete duplication #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he test has been marked as incomplete - If you marked a test as incomplete with no assertions in it, and then ran the test with --strict mode it would report two incomplete results for the one test which is incorrect
|
Pulled, thanks. |
axiac
pushed a commit
to axiac/phpunit
that referenced
this pull request
May 8, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A colleague found an issue with the --strict option when used in tests that have no assertions and are marked as incomplete. If you mark a test with no assertions as incomplete you would end up with two incomplete results for the same test which is confusing and technically wrong.
This pull request fixes that issue