Removed ctype extension dependency

[eelf]

Tests passed: OK (1246 tests, 1863 assertions)
I have no PEAR_RunTest class for running phpt tests :(

[whatthejeff]

I think this code is fundamentally flawed. Not all platforms use drive letters. For instance, 'c:/tests' is a relative path on posix platforms.

I know CPython has a more thorough treatment of this in the form of os.path.isabs. For reference:

• http://hg.python.org/cpython/file/206685a4b19c/Lib/ntpath.py#l90
• http://hg.python.org/cpython/file/206685a4b19c/Lib/posixpath.py#l57

[Tatsh]

        if ($path[0] === '/' || $path[0] === '\\' ||
           (strlen($path) > 3 && preg_match('/[a-zA-Z]/', $path[0]) &&
              $path[1] === ':' && ($path[2] === '\\' || $path[2] === '/'))) {

Because the path length check is there, it doesn't seem like c:/tests would fail. It would correctly hit the 3rd path in the if as long as $path is lower-cased before this check.

An OS check should be added maybe?

[whatthejeff]

Because the path length check is there, it doesn't seem like c:/tests would fail.

But it should fail on POSIX platforms.

It would correctly hit the 3rd path in the if as long as $path is lower-cased before this check.

This is not the correct behavior for POSIX platforms.

An OS check should be added maybe?

Yes, this is exactly what I'm proposing. Consider the following:

POSIX absolute path:

/home/whatthejeff/tests

NT absolute path:

c:\Users\whatthejeff\tests
\\machine\mountpoint\tests

[glensc]

is pcre_match locale insensitive? because if it's sensitive, A-Z does not match "the alphabet" when locale is for example et_EE

[Tatsh]

preg_match is locale insensitive unless /u modifier is used (which makes the regular expression specific to PHP).

The correct fix is to check for Windows somewhere (plenty of ways to do that, defined('PHP_WINDOWS_VERSION_BUILD') is one cheap way) and then proceed on one of two paths based on that result: Windows or POSIX.

[Tatsh]

New pull request with basic OS check:
#1010

[whatthejeff]

Closing this in favor of #1010.