Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further changes to make zipper compatible for additional systems #8

Merged
merged 13 commits into from
May 5, 2017

Conversation

fbergmann
Copy link
Collaborator

I'm not actually sure you want to merge this back, but i thought i let you know. I needed the api to compile on systems that are not yet capable of running c++11. In any case, please have a look and see what works for you.

@sebastiandev
Copy link
Owner

Hey there... well.. i not sure about this. Do you know other people that might benefit from this? Someone interested on the library that cannot use c++11 yet?

I kinda like the simplicity that c++11 offered to make the code smaller, clearer and elegant so to speak.

I'll leave this open a couple of days.

@fbergmann
Copy link
Collaborator Author

Like I said before I'm not sure either the feedback I received so far is that the dependency on the c++17 STL or boost would be too cumbersome. So I might have to even reimplement the filesystem bits in plain c.i can understand if that is not the direction you want to take this.

@sebastiandev
Copy link
Owner

Hey there, im back a little late, but finally back. It looks like theres a conflict with the tools source?
if thats resolved i guess we can merge everything

@fbergmann
Copy link
Collaborator Author

so what changed between now and then, was that i removed all the dependency on the different file system api's in favor of taking the one from our project, where we encapsulated everything before. I think starting from my version and using your

133829b

it should work fine again

@sebastiandev sebastiandev merged commit 787b97d into sebastiandev:master May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants