Set parameters for gpg encryption #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianfeldmann
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that gpg encryption does not work as per #369.
Seems that the gpg executable wasn't given any parameters at all.
So I added those. Also modified the user parameter, which needs an username (email) of the gpg key in your keychain that you intend to encrypt the backup with.
Be noted that the key should be trusted, otherwise the gpg prompts for input, letting the backup hang. Maybe all keys could be automatically trusted with some parameter, or phpbu should check that the key is trusted beforehand.
Also, gpg by default compresses the file. That could also be configured.