-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
track flutter.compileSdkVersion with nsd_android/android/build.gradle compileSdkVersion? #17
Comments
Hi @repentsinner, are you attempting to compile the plugin / example with an Android SDK below 32? If that's the case, just update your SDK to 32 and you should be fine. It is strongly recommended that you always compile with the latest SDK - see this Article by Ian Lake (Google). P.S.: that reminds me, I should add the minimum requirements for the plugin to the README. |
Thanks for the quick reply @sebastianhaberey. I'm using boilerplate
Over in the flutter source for stable (as of today, 2.10.5), flutter.compileSdkVersion is (still) defined as 31: I had a quick look through flutter's issues and other tags/branches and I don't see much discussion/attempt to move it to 32 (even in the newly released flutter 3.0.0) which to your point and Google best practices does seem odd. If nsd requires a feature of 32 and the main flutter distribution is still using 31, it might be worth making a note in the docs that this should be overridden (but you updated to note that it only requires min 21). If not, does it make sense to just track flutter.compileSdkVersion in nsd's build.gradle so that it'll work with whatever's current, and puts the onus on flutter to correctly manage SdkVersions? |
First off, you're right - I didn't consider that a freshly generated app would have a Also, I agree that it would be nice to have something like It seems that the Flutter team is maintaining the Please give the new version (1.5.3) a try and see if it works for you! |
Looks good to me, thanks! FWIW I opened an issue on the main flutter project to ask why they're still using SDK 31, curious what they say about that. |
Should the compileSdkVersion in
nsd_android/android/build.gradle
be reverted to 31 along with the change in f7a891a? I'm getting a build warning:Thanks!
The text was updated successfully, but these errors were encountered: