-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for IP addresses #7
Comments
If you are searching for use case examples we are here. It currently shows the users all devices IPs on the local network.
You can see an example for the result in a close source app named Network Scanner Without IP there is no way for us to associate an mDNS name to our existing IP list and show the user the full information about each IP. |
Since this feature seems somewhat popular, I will have a look at adding an option to look up IPs. |
- added addresses property to Service - added option "ipLookupType" to configure ip lookup - added integration test for ip lookup - added some test helper functions
The latest version (1.3.0) now has an final discovery = await startDiscovery(serviceType, ipLookupType: IpLookupType.any); This will populate the new attribute |
This seems to be a common request, so I'm adding this issue for discussion. I'm still unsure if IP addresses should be part of this API, or if they are out of scope. My understanding is that connecting to a resolved service can and should be done using the host name / port combination. Apple representative "Eskimo" writes on their developer forum:
So I'd like to hold out implementing this feature until I'm more certain about its use cases. Feel free to comment here.
The text was updated successfully, but these errors were encountered: