Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking api change #7

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

FabianMeul
Copy link
Contributor

@FabianMeul FabianMeul commented Apr 15, 2020

Because of the change made in this commit (54b9df7#diff-f41e9d04a45c83f3b6f6e630f10117fe) going from an anonymous export to a named export, the library does not work as described in the README.

This PR aims to restore the default behaviour.

Current behaviour of the published package:

const jestModuleNameMapper = require('jest-module-name-mapper').bootstrap();

Expected behaviour in this PR:

const jestModuleNameMapper = require('jest-module-name-mapper')();

 Because of the change you made (sebastianmusial@54b9df7#diff-f41e9d04a45c83f3b6f6e630f10117fe) going from an anonymous export to a named export, the library does not work as described in the README.

This PR aims to restore the default behaviour.
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master        #7   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            5         5           
  Branches         1         1           
=========================================
  Hits             5         5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bde86e...ae932c8. Read the comment docs.

@sebastianmusial sebastianmusial self-requested a review April 15, 2020 12:51
@FabianMeul
Copy link
Contributor Author

FabianMeul commented Apr 15, 2020

Thanks for approving the changes!

Any idea on when this might get merged (and published)? :-)

@sebastianmusial
Copy link
Owner

@FabianMeul Today 🎉

@sebastianmusial sebastianmusial merged commit f45978f into sebastianmusial:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants