Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New results and datasets: Document Dating and Open KB Canonicalization #49

Merged
merged 11 commits into from
Jul 11, 2018

Conversation

svjan5
Copy link
Contributor

@svjan5 svjan5 commented Jul 11, 2018

No description provided.

@sebastianruder
Copy link
Owner

This is great, thank you! Two things:

  • Instead of creating Document Dating and Open Knowledge Base Canonicalization as their own top-level topics, could you instead create top-level topics Information Extraction and Temporal Processing and add Open KB Canonicalization to IE and Document Dating to Temporal Processing (and add them to the table of contents in alphabetical order)? There are a couple of other tasks in this PR (New tasks (temporal, stance) and new datasets (soc med in NER, POS) #27) that also fit in Temporal processing.
  • Could you add "new result" to the PR title to indicate that new results are being added (so that we can track these)?

@svjan5 svjan5 changed the title Added two problems: Document Dating and Open KB Canonicalization New results and datasets: Document Dating and Open KB Canonicalization Jul 11, 2018
@svjan5
Copy link
Contributor Author

svjan5 commented Jul 11, 2018

Hi Sebastian,
I have made the changes. Please check.

@sebastianruder
Copy link
Owner

Thanks! Could you use the same format as in the other tables, i.e. add the author name and year to the methods in brackets and add the paper name and link in a separate column?
Could you also make it so that the table of contents is sorted alphabetically?

@svjan5
Copy link
Contributor Author

svjan5 commented Jul 11, 2018

Sure, incorporated the changes.

@sebastianruder
Copy link
Owner

Thanks! Could you do the same for the table in document dating?

@svjan5
Copy link
Contributor Author

svjan5 commented Jul 11, 2018

Yes, I did for both.

@sebastianruder
Copy link
Owner

Thanks! One last thing: Could you sort both tables so that the best score is at the top?

@svjan5
Copy link
Contributor Author

svjan5 commented Jul 11, 2018

Sure, Done!

@sebastianruder
Copy link
Owner

👍

@sebastianruder sebastianruder merged commit 4bf20d0 into sebastianruder:master Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants