Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Korean and Hindi #116

Closed
wants to merge 6 commits into from
Closed

Add Korean and Hindi #116

wants to merge 6 commits into from

Conversation

NirantK
Copy link
Collaborator

@NirantK NirantK commented Oct 4, 2018

As per discussion in #79, adding prelim sections for Hindi and Korean, YAMLized.

  • Next: Will expand Hindi and add other languages if this looks okay to both of us.
  • Help: Adding 'score='BLUE' to the markdown does not add machine translation metrics to HTML. Any hints?
  • Request: Please squash commits when merging

@sebastianruder
Now that I've tried the YML versions, I am all the more in favor of human-readable Markdowns.

Pros:

  • Easier trend spotting in performance improvements

Cons:

  • Hard for contributors, e.g. I can't spot HTML omissions without setting up Jekyll locally
  • Github Repo becomes useless for readers, relying exclusively on nlpsota.com

@NirantK NirantK added the enhancement New feature or request label Oct 4, 2018
@sebastianruder
Copy link
Owner

Hi @NirantK,

Great, thanks a lot!
Re help: You need to specify scores instead of score and the metric needs to have the same name as in the Table (see my commit here).
Re squashing commits: Cool. I actually wasn't aware of this feature. Thanks for pointing me to it. :)

Re YAML: Fair point and I see where you're coming from. At the moment, I think the benefit of YAML is indeed limited. Let's discuss this in a separate issue.

@NirantK
Copy link
Collaborator Author

NirantK commented Oct 4, 2018

  1. Thanks for the 'scores' commit and tip!
  2. Sure, let's discuss that separately. Please squash and merge this so that I can start pointing people working on Hindi to here :)

@sebastianruder
Copy link
Owner

Sure. I think you just need to update the scores yourself unfortunately as pushing my commit didn't add it to this one, but created a separate branch. :-/ The scores for Korean also still need to be fixed.

@NirantK
Copy link
Collaborator Author

NirantK commented Oct 4, 2018

Got it, closing this in favour of a new PR with your commit

@NirantK NirantK closed this Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants