Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin manager #24

Closed
ghost opened this issue Dec 24, 2017 · 7 comments
Closed

Plugin manager #24

ghost opened this issue Dec 24, 2017 · 7 comments

Comments

@ghost
Copy link

ghost commented Dec 24, 2017

I started to help Andrew with the plugin manager ;)

somehow your zip file is corrupt.. if i compile it myself it works just nice without asking for an update (red dot) but if i choose yours on vcvrack.com (plugin manager) it will let me know that there is a "new" module pack available.. therefor something is not working right with your zip file.
i actually tried to make a new sha256 but this also didnt solve it...
when i tried to do "make dist" it cried error.. in case of creating a zip file

so if you need help to fix your module pack let me know e.g here or on FB (Struggl Michael)

@sebastien-bouffier
Copy link
Owner

Hello Michael I will try to fix it asap.

@sebastien-bouffier
Copy link
Owner

Just pushed 0.5.10 and updated my json in Community. Hope it will fix the issue. I tried to unzip the dist archive on my computer and it works fine, VirusTotal didn't see any issue on the zip file, sha key should be good too. Once the pull request on Community will be accepted I will perform a test to check if the update plugin light still appear. Best.

@sebastien-bouffier
Copy link
Owner

Andrew merged my pull request. I deleted all the content of my Documents/Rack/Plugins. Deselected all plugins from my account on the website ... As expected I only have Core and Fundamentals plugins but ... but ... but ... red light still there. So it will be difficult to say if it is an issue on my pack.
Best.

@ghost
Copy link
Author

ghost commented Jan 3, 2018

write you here now again as you mentioned that you are not that much on FB ;)
your package is now fixed (no more red dot)

please, always change the version number in your json file aswell when you make a pull request..
looks like we all have overseen this :)

@sebastien-bouffier
Copy link
Owner

sebastien-bouffier commented Jan 3, 2018

OK even if there are no change to the source ? I work on W10 and I depend on users kindness for Lin and Mac dist so when they send me a dist for another platform than W10 I will have to change the version ?

@ghost
Copy link
Author

ghost commented Jan 3, 2018

no as you provide them already with the correct makefile they just compile it ;)

the version number in the makefile and the version number in the json file needs to be ident. it doesnt matter for which OS it will be compiled..

so if you create a new version e.g. -> version = "0.5.3"
the version number in the makefile and the json file needs to be changed to version = "0.5.3"

I hope I discribed it properly.. I m not a pro in english :D

@sebastien-bouffier
Copy link
Owner

Clear enough for me thanks a lot Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant