Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You need an evil-company-box-state #14

Closed
Alexander-Miller opened this issue Apr 26, 2018 · 7 comments
Closed

You need an evil-company-box-state #14

Alexander-Miller opened this issue Apr 26, 2018 · 7 comments

Comments

@Alexander-Miller
Copy link
Contributor

Same reason I need my own treemacs-evil. Setting a cursor-type won't do since evil is managing your cursor. You need to define a proper evil state and activate it in the company-box buffer.

I can make the necessary changes, just let me know if you want this to be part of the main package (so as to avoid the awkward not-really dependency on evil) or if it should go into its own file and package.

@sebastiencs
Copy link
Owner

sebastiencs commented Apr 27, 2018

I can make the necessary changes, just let me know if you want this to be part of the main package

Yes please, that would be great, I think it should stay in the package.

You need to define a proper evil state and activate it in the company-box buffer.

The company-box buffer and its frame are never selected, commands are executed "remotely" from the current buffer. So I'm not sure if you're right about that, but since I know nothing about evil...

@noctuid
Copy link
Contributor

noctuid commented May 6, 2018

There doesn't seem to be a cursor displayed in the company-box buffer even with evil. What is the problem this would address?

@Alexander-Miller
Copy link
Contributor Author

It's definitely around for me. I've now removed it from the main window, but it's still visible in the scrollbar.

@noctuid
Copy link
Contributor

noctuid commented May 6, 2018

I think I can replicate that. Changing cursor-in-non-selected-windows to nil should be a sufficient fix though. I don't think there's a need to do anything specifically related to evil.

@Alexander-Miller
Copy link
Contributor Author

Not everyone will want to change global settings to accommodate company-box. And it's not like the fix is all that complicated or expensive. It's just one trivial function and 1 or 2 well placed hooks to call it.

@noctuid
Copy link
Contributor

noctuid commented May 6, 2018

I was suggesting setting it locally not globally.

noctuid added a commit to noctuid/company-box that referenced this issue May 6, 2018
sebastiencs pushed a commit that referenced this issue May 7, 2018
@Alexander-Miller
Copy link
Contributor Author

Ah, I thought it was a global variable. Never mind then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants