Prepare for NET 8 analyzers #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +28,7 @@ public override string ToString() | |||
| writer.WriteLineComment(Value, JavaScriptTextWriter.TriviaFlags.None); | |||
| break; | |||
| case CommentType.Block: | |||
| writer.WriteBlockComment(Value.Split(new[] { "\r\n", "\r", "\n" }, StringSplitOptions.None), JavaScriptTextWriter.TriviaFlags.None); | |||
| @@ -198,6 +198,14 @@ internal static bool Contains(this string source, char c) | |||
| } | |||
| #endif | |||
|
|
|||
| #if NETFRAMEWORK || NETSTANDARD2_0 | |||
There was a problem hiding this comment.
Note on newer versions it uses vectorization (you know). We might want to use these and IndexOf as much as possible. I believe it's a jit thing though so it shouldn't require custom tfms.
There was a problem hiding this comment.
Yes I think the interesting case is to detect whether string contains something before doing replace, like in https://github.com/RicoSuter/NJsonSchema/pull/1638/files . It's not ideal with current TFMs, but maybe SearchValues would fit the bill nicely - just to check something before doing and expensive chain of replaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another set of tweaks that NET 8 analyzers complain about.